From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, rearnsha@arm.com
Subject: [rfc] Remove LOWEST_PC macro
Date: Thu, 15 Nov 2007 09:24:00 -0000 [thread overview]
Message-ID: <473C0FC3.1020507@de.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
Hi,
this patch replaces the only occurence of LOWEST_PC macro in arm target by itsexpression and replaces
current_gdbarch with get_frame_arch.
Tested by builing arm target. Ok to commit?
ChangeLog:
* arm-tdep.c (arm_prologue_this_id): Replace LOWEST_PC by its
expression and use get_frame_arch to replace current_gdbarch by frame's
architecture.
* arm-tdep.h (LOWEST_PC): Remove.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
[-- Attachment #2: diff-arm-tdep --]
[-- Type: text/plain, Size: 979 bytes --]
diff -urpN src/gdb/arm-tdep.c dev/gdb/arm-tdep.c
--- src/gdb/arm-tdep.c 2007-11-07 07:32:59.000000000 +0100
+++ dev/gdb/arm-tdep.c 2007-11-15 10:13:09.000000000 +0100
@@ -961,7 +961,7 @@ arm_prologue_this_id (struct frame_info
/* This is meant to halt the backtrace at "_start". Make sure we
don't halt it at a generic dummy frame. */
- if (func <= LOWEST_PC)
+ if (func <= gdbarch_tdep (get_frame_arch (next_frame))->lowest_pc)
return;
/* If we've hit a wall, stop. */
diff -urpN src/gdb/arm-tdep.h dev/gdb/arm-tdep.h
--- src/gdb/arm-tdep.h 2007-10-10 16:04:53.000000000 +0200
+++ dev/gdb/arm-tdep.h 2007-11-15 10:06:29.000000000 +0100
@@ -176,11 +176,6 @@ struct gdbarch_tdep
};
-
-#ifndef LOWEST_PC
-#define LOWEST_PC (gdbarch_tdep (current_gdbarch)->lowest_pc)
-#endif
-
CORE_ADDR arm_skip_stub (struct frame_info *, CORE_ADDR);
CORE_ADDR arm_get_next_pc (struct frame_info *, CORE_ADDR);
int arm_software_single_step (struct frame_info *);
next reply other threads:[~2007-11-15 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 9:24 Markus Deuling [this message]
2007-11-15 13:41 ` Daniel Jacobowitz
2007-11-15 13:55 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473C0FC3.1020507@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=rearnsha@arm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox