From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31016 invoked by alias); 15 Nov 2007 09:24:07 -0000 Received: (qmail 31007 invoked by uid 22791); 15 Nov 2007 09:24:06 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 Nov 2007 09:24:04 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id lAF9O0SC113488 for ; Thu, 15 Nov 2007 09:24:00 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.6) with ESMTP id lAF9O0DX1650824 for ; Thu, 15 Nov 2007 10:24:00 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lAF9NxPv028890 for ; Thu, 15 Nov 2007 10:24:00 +0100 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-41.boeblingen.de.ibm.com [9.152.248.41]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lAF9Nwdq028834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 15 Nov 2007 10:23:59 +0100 Message-ID: <473C0FC3.1020507@de.ibm.com> Date: Thu, 15 Nov 2007 09:24:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand , rearnsha@arm.com Subject: [rfc] Remove LOWEST_PC macro Content-Type: multipart/mixed; boundary="------------060503010807080002050907" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00302.txt.bz2 This is a multi-part message in MIME format. --------------060503010807080002050907 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 464 Hi, this patch replaces the only occurence of LOWEST_PC macro in arm target by itsexpression and replaces current_gdbarch with get_frame_arch. Tested by builing arm target. Ok to commit? ChangeLog: * arm-tdep.c (arm_prologue_this_id): Replace LOWEST_PC by its expression and use get_frame_arch to replace current_gdbarch by frame's architecture. * arm-tdep.h (LOWEST_PC): Remove. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------060503010807080002050907 Content-Type: text/plain; name="diff-arm-tdep" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-arm-tdep" Content-length: 979 diff -urpN src/gdb/arm-tdep.c dev/gdb/arm-tdep.c --- src/gdb/arm-tdep.c 2007-11-07 07:32:59.000000000 +0100 +++ dev/gdb/arm-tdep.c 2007-11-15 10:13:09.000000000 +0100 @@ -961,7 +961,7 @@ arm_prologue_this_id (struct frame_info /* This is meant to halt the backtrace at "_start". Make sure we don't halt it at a generic dummy frame. */ - if (func <= LOWEST_PC) + if (func <= gdbarch_tdep (get_frame_arch (next_frame))->lowest_pc) return; /* If we've hit a wall, stop. */ diff -urpN src/gdb/arm-tdep.h dev/gdb/arm-tdep.h --- src/gdb/arm-tdep.h 2007-10-10 16:04:53.000000000 +0200 +++ dev/gdb/arm-tdep.h 2007-11-15 10:06:29.000000000 +0100 @@ -176,11 +176,6 @@ struct gdbarch_tdep }; - -#ifndef LOWEST_PC -#define LOWEST_PC (gdbarch_tdep (current_gdbarch)->lowest_pc) -#endif - CORE_ADDR arm_skip_stub (struct frame_info *, CORE_ADDR); CORE_ADDR arm_get_next_pc (struct frame_info *, CORE_ADDR); int arm_software_single_step (struct frame_info *); --------------060503010807080002050907--