Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>
Subject: [rfc] [05/09] Get rid of current_gdbarch (macros in mn10300 target)
Date: Mon, 05 Nov 2007 12:23:00 -0000	[thread overview]
Message-ID: <472F0ACD.4010503@de.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi, 

this patch replaces AM33 macro from n10300 target and then replaces current_gdbarch
by appropriate methods. 

Tested building with --target=mn10300. Ok to commit?


ChangeLog:

	* mn10300-tdep.c (set_reg_offsets,mn10300_analyze_prologue): Replace
	AM33 by its expression. Use get_frame_arch to get at the current
	architecture by frame_info.
	* mn10300-tdep.h (AM33_MODE): Remove.


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com





[-- Attachment #2: diff-mn10300 --]
[-- Type: text/plain, Size: 1420 bytes --]

diff -urpN src/gdb/mn10300-tdep.c dev2/gdb/mn10300-tdep.c
--- src/gdb/mn10300-tdep.c	2007-11-05 05:32:22.000000000 +0100
+++ dev2/gdb/mn10300-tdep.c	2007-11-05 09:10:03.000000000 +0100
@@ -328,7 +328,7 @@ set_reg_offsets (struct frame_info *fi, 
 
   trad_frame_set_this_base (cache, base);
 
-  if (AM33_MODE == 2)
+  if (gdbarch_tdep (get_frame_arch (fi))->am33_mode == 2)
     {
       /* If bit N is set in fpregmask, fsN is saved on the stack.
 	 The floating point registers are saved in ascending order.
@@ -384,7 +384,7 @@ set_reg_offsets (struct frame_info *fi, 
       trad_frame_set_reg_addr (cache, E_D2_REGNUM, base + offset);
       offset += 4;
     }
-  if (AM33_MODE)
+  if (gdbarch_tdep (get_frame_arch (fi))->am33_mode)
     {
       if (movm_args & movm_exother_bit)
         {
@@ -603,7 +603,7 @@ mn10300_analyze_prologue (struct frame_i
 	goto finish_prologue;
     }
 
-  if (AM33_MODE == 2)
+  if (gdbarch_tdep (get_frame_arch (fi))->am33_mode == 2)
     {
       /* Determine if any floating point registers are to be saved.
 	 Look for one of the following three prologue formats:
diff -urpN src/gdb/mn10300-tdep.h dev2/gdb/mn10300-tdep.h
--- src/gdb/mn10300-tdep.h	2007-08-23 20:08:36.000000000 +0200
+++ dev2/gdb/mn10300-tdep.h	2007-11-05 09:10:12.000000000 +0100
@@ -77,4 +77,3 @@ struct gdbarch_tdep
   int am33_mode;
 };
 
-#define AM33_MODE (gdbarch_tdep (current_gdbarch)->am33_mode)




             reply	other threads:[~2007-11-05 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 12:23 Markus Deuling [this message]
2007-11-05 15:53 ` Ulrich Weigand
2007-11-06 12:07   ` Markus Deuling
2007-11-06 18:37     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472F0ACD.4010503@de.ibm.com \
    --to=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox