Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches)
Subject: Re: [rfc] [05/09] Get rid of current_gdbarch (macros in mn10300 target)
Date: Mon, 05 Nov 2007 15:53:00 -0000	[thread overview]
Message-ID: <200711051553.lA5FrLSM021755@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <472F0ACD.4010503@de.ibm.com> from "Markus Deuling" at Nov 05, 2007 01:21:33 PM

Markus Deuling wrote:

> 	* mn10300-tdep.c (set_reg_offsets,mn10300_analyze_prologue): Replace
> 	AM33 by its expression. Use get_frame_arch to get at the current
> 	architecture by frame_info.
> 	* mn10300-tdep.h (AM33_MODE): Remove.

Sorry, but this is not OK.  Unfortunately, the mn10300_analyze_prologue
routine is called both from within the unwinder (where we always have
a frame), *and* from mn10300_skip_prologue, where frame information is
not available.  Thus "fi" may actually be NULL.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2007-11-05 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 12:23 Markus Deuling
2007-11-05 15:53 ` Ulrich Weigand [this message]
2007-11-06 12:07   ` Markus Deuling
2007-11-06 18:37     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711051553.lA5FrLSM021755@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox