From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [rfc] [13/17] Get rid of current_gdbarch in win32-nat.c
Date: Mon, 22 Oct 2007 06:09:00 -0000 [thread overview]
Message-ID: <471C3D22.2040903@de.ibm.com> (raw)
In-Reply-To: <20071011175153.GA443@ednor.casa.cgf.cx>
Hi Christopher,
Christopher Faylor schrieb:
> On Thu, Oct 11, 2007 at 10:54:14AM +0200, Markus Deuling wrote:
>> this patch gets rid of some of the current_gdbarch's in win32-nat.c. Maybe
>> someone can test this? I have no idea how to :-)
>> Thanks a lot. Is this ok to commit?
>>
>> ChangeLog:
>>
>> * win32-nat.c (do_win32_fetch_inferior_registers, win32_resume)
>> (do_win32_store_inferior_registers): Use get_regcache_arch to get at
>> the current architecture by regcache.
>
> I'm sorry. I'm a little confused. If you're offering a patch why can't
> you test it? Wouldn't that be considered a prerequisite for a patch?
>
> cgf
>
you're right. One should test a patch before posting it ;-) But this patch is a mechanical change. Thats the reason
I ask a responsible maintainer to have a look at it instead of setting up an environment to test GDB on Windows (cygwin) myself.
Thank you for your objection and sry for the late response. I've been on vacation.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
prev parent reply other threads:[~2007-10-22 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 8:55 Markus Deuling
2007-10-11 17:59 ` Christopher Faylor
2007-10-22 6:09 ` Markus Deuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471C3D22.2040903@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox