From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21080 invoked by alias); 22 Oct 2007 06:04:58 -0000 Received: (qmail 21069 invoked by uid 22791); 22 Oct 2007 06:04:57 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 22 Oct 2007 06:04:56 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9M64rDo107256 for ; Mon, 22 Oct 2007 06:04:53 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9M64rsU1941690 for ; Mon, 22 Oct 2007 08:04:53 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9M64qke008122 for ; Mon, 22 Oct 2007 08:04:52 +0200 Received: from bbkeks.boeblingen.de.ibm.com (dyn-9-152-248-41.boeblingen.de.ibm.com [9.152.248.41]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l9M64pgb008087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 22 Oct 2007 08:04:52 +0200 Message-ID: <471C3D22.2040903@de.ibm.com> Date: Mon, 22 Oct 2007 06:09:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: GDB Patches Subject: Re: [rfc] [13/17] Get rid of current_gdbarch in win32-nat.c References: <470DE4B6.1050708@de.ibm.com> <20071011175153.GA443@ednor.casa.cgf.cx> In-Reply-To: <20071011175153.GA443@ednor.casa.cgf.cx> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00489.txt.bz2 Hi Christopher, Christopher Faylor schrieb: > On Thu, Oct 11, 2007 at 10:54:14AM +0200, Markus Deuling wrote: >> this patch gets rid of some of the current_gdbarch's in win32-nat.c. Maybe >> someone can test this? I have no idea how to :-) >> Thanks a lot. Is this ok to commit? >> >> ChangeLog: >> >> * win32-nat.c (do_win32_fetch_inferior_registers, win32_resume) >> (do_win32_store_inferior_registers): Use get_regcache_arch to get at >> the current architecture by regcache. > > I'm sorry. I'm a little confused. If you're offering a patch why can't > you test it? Wouldn't that be considered a prerequisite for a patch? > > cgf > you're right. One should test a patch before posting it ;-) But this patch is a mechanical change. Thats the reason I ask a responsible maintainer to have a look at it instead of setting up an environment to test GDB on Windows (cygwin) myself. Thank you for your objection and sry for the late response. I've been on vacation. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com