[rfc] Define PTRACE_GETSIGINFO in linux-nat.c

[rfc] Define PTRACE_GETSIGINFO in linux-nat.c

[Markus Deuling]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi,

the new save_siginfo() function from linux-nat.c breaks my build on

  Linux bbkeks 2.6.9-55.0.6.EL #1 Thu Aug 23 10:59:21 EDT 2007 i686 i686 i386 GNU/Linux

because PTRACE_GETSIGINFO isn't defined in the includes. The patch takes over definition of it from ppc-linux-nat.c


ChangeLog:

	* linux-nat.c (PTRACE_GETSIGINFO): Add define.

Tested on x86.

Is this ok to commit or would it be better to move it to a header (linux-nat.h ?) file and delete it from ppc-linux-nat.c as well to prevent 
redundancy?

Regards,
Markus

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff-PTRACE_GETSIGINFO --]
[-- Type: text/plain, Size: 497 bytes --]

diff -urpN src/gdb/linux-nat.c dev/gdb/linux-nat.c
--- src/gdb/linux-nat.c	2007-10-01 09:00:51.000000000 +0200
+++ dev/gdb/linux-nat.c	2007-10-02 08:43:40.000000000 +0200
@@ -84,6 +84,10 @@
 #define __WALL          0x40000000 /* Wait for any child.  */
 #endif
 
+#ifndef PTRACE_GETSIGINFO
+#define PTRACE_GETSIGINFO    0x4202
+#endif
+
 /* The single-threaded native GNU/Linux target_ops.  We save a pointer for
    the use of the multi-threaded target.  */
 static struct target_ops *linux_ops;

Re: [rfc] Define PTRACE_GETSIGINFO in linux-nat.c

[Daniel Jacobowitz]

On Tue, Oct 02, 2007 at 08:59:44AM +0200, Markus Deuling wrote:
> ChangeLog:
> 
> 	* linux-nat.c (PTRACE_GETSIGINFO): Add define.
> 
> Tested on x86.

I'm really sorry.  Two people told me about this and I still forgot to
fix it before I committed.  Patch is OK.

> Is this ok to commit or would it be better to move it to a header (linux-nat.h 
> ?) file and delete it from ppc-linux-nat.c as well to prevent redundancy?

ppc-linux-nat.c doesn't need it any more; you can just delete that
copy.  I removed the use.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [rfc] Define PTRACE_GETSIGINFO in linux-nat.c

[Ulrich Weigand]

Daniel Jacobowitz wrote:
> On Tue, Oct 02, 2007 at 08:59:44AM +0200, Markus Deuling wrote:
> > ChangeLog:
> > 
> > 	* linux-nat.c (PTRACE_GETSIGINFO): Add define.
> > 
> > Tested on x86.
> 
> I'm really sorry.  Two people told me about this and I still forgot to
> fix it before I committed.  Patch is OK.

I've checked this in now.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com