Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Report additional details for signals received on FreeBSD.
Date: Thu, 3 Jun 2021 13:06:27 -0400	[thread overview]
Message-ID: <46d9f7c8-9984-0938-a647-39daad3cdea2@polymtl.ca> (raw)
In-Reply-To: <25c1c5b7-5081-1bdb-c8a2-0b95ae22fa28@FreeBSD.org>

> Hmm, would you like it in the commit log?  Here are some sample before/after
> comparisons:
> 
> SIGUSR1 raised by kill():
> 
> before:
> 
> Program received signal SIGUSR1, User defined signal 1.
> kill () at kill.S:4
> 4       RSYSCALL(kill)
> 
> 
> after:
> 
> Program received signal SIGUSR1, User defined signal 1.
> Sent by kill() from pid 30529 and user 1001.
> kill () at kill.S:4
> 4       RSYSCALL(kill)
> 
> SIGCHLD for exited process:
> 
> before:
> 
> Program received signal SIGCHLD, Child status changed.
> 
> after:
> 
> Program received signal SIGCHLD, Child status changed.
> Child has exited: pid 31929, uid 1001, exit status 0.
> 
> SIGALRM raised by a POSIX timer (timer_create):
> 
> before:
> 
> Program received signal SIGALRM, Alarm clock.
> 
> after:
> 
> Program received signal SIGALRM, Alarm clock.
> Timer expired: timerid 3.

Thanks, that's nice.  I'd personally put them in the commit message, but
it's as you wish.

Simon

      reply	other threads:[~2021-06-03 17:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 16:29 John Baldwin
2021-05-31 16:33 ` John Baldwin
2021-06-01  0:49   ` Simon Marchi via Gdb-patches
2021-06-03 17:01     ` John Baldwin
2021-06-03 17:06       ` Simon Marchi via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46d9f7c8-9984-0938-a647-39daad3cdea2@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox