From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RKYkGTAMuWCLIAAAWB0awg (envelope-from ) for ; Thu, 03 Jun 2021 13:06:56 -0400 Received: by simark.ca (Postfix, from userid 112) id 5982C1F163; Thu, 3 Jun 2021 13:06:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B44DC1E939 for ; Thu, 3 Jun 2021 13:06:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 15D2E398EC23 for ; Thu, 3 Jun 2021 17:06:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15D2E398EC23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1622740015; bh=Z4bRp/LnLEc6RS/9GIoy2InpV4nWTSTwC8250DTOXh4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=rfK+iN8VaCFPHTC1nxLnUGMn1vcGj/xfeCpOkyvvr1Cm+Q9ICvAfNh4nxcS241KqF CsL4omPv7qmVF14o7boskyg0+UCij02nOeOhtksDkfuK9i4NMDxtZe/Vj/ueiyxGfs +2Uenh3ye+4EYRSPmV/BpJAlPEb7/fzMnhmo2+Cw= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9DEB03857000 for ; Thu, 3 Jun 2021 17:06:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DEB03857000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 153H6Rgf032700 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 Jun 2021 13:06:32 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 153H6Rgf032700 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DAF6A1E939; Thu, 3 Jun 2021 13:06:27 -0400 (EDT) Subject: Re: [PATCH] Report additional details for signals received on FreeBSD. To: John Baldwin , gdb-patches@sourceware.org References: <20210531162940.10841-1-jhb@FreeBSD.org> <46124956-89f0-4da0-00cd-476584b50e98@FreeBSD.org> <25c1c5b7-5081-1bdb-c8a2-0b95ae22fa28@FreeBSD.org> Message-ID: <46d9f7c8-9984-0938-a647-39daad3cdea2@polymtl.ca> Date: Thu, 3 Jun 2021 13:06:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <25c1c5b7-5081-1bdb-c8a2-0b95ae22fa28@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 3 Jun 2021 17:06:28 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Hmm, would you like it in the commit log? Here are some sample before/after > comparisons: > > SIGUSR1 raised by kill(): > > before: > > Program received signal SIGUSR1, User defined signal 1. > kill () at kill.S:4 > 4 RSYSCALL(kill) > > > after: > > Program received signal SIGUSR1, User defined signal 1. > Sent by kill() from pid 30529 and user 1001. > kill () at kill.S:4 > 4 RSYSCALL(kill) > > SIGCHLD for exited process: > > before: > > Program received signal SIGCHLD, Child status changed. > > after: > > Program received signal SIGCHLD, Child status changed. > Child has exited: pid 31929, uid 1001, exit status 0. > > SIGALRM raised by a POSIX timer (timer_create): > > before: > > Program received signal SIGALRM, Alarm clock. > > after: > > Program received signal SIGALRM, Alarm clock. > Timer expired: timerid 3. Thanks, that's nice. I'd personally put them in the commit message, but it's as you wish. Simon