From: Maxim Grigoriev <maxim@tensilica.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Adding support for Xtensa Call0 ABI
Date: Sat, 18 Aug 2007 00:56:00 -0000 [thread overview]
Message-ID: <46C643C2.4000405@hq.tensilica.com> (raw)
In-Reply-To: <20070818002156.GA24165@adacore.com>
Joel Brobecker wrote:
>> Since adding new ABI support is a big patch I considered
>> that as a good opportunity to reformat comments
>> (capitals, spaces after periods, etc) and do some
>> minor clean-ups to match coding standard.
>>
>
> Actually, it's cleaner if you could separate the formatting-only
> patch from the real change. The formatting changes just clutter
> your patch, and make it harder for us to review your changes.
>
I was thinking clean-ups are pretty straight forward.
I got your point for the future and will separate patches
covering different issues. I'm sorry for any inconvenience.
> Is this worth a NEWS entry?
>
Well, I don't feel like it is. In the near future, I plan to submit
Xtensa GNU Linux support introducing new target. That would be a
true addition to the NEWS and good opportunity to mention that FSF
Xtensa GDB supports both ABIs.
-- Maxim
prev parent reply other threads:[~2007-08-18 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 21:54 Maxim Grigoriev
2007-08-18 0:18 ` Joel Brobecker
2007-08-18 0:56 ` Maxim Grigoriev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C643C2.4000405@hq.tensilica.com \
--to=maxim@tensilica.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox