From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 883 invoked by alias); 18 Aug 2007 00:56:42 -0000 Received: (qmail 850 invoked by uid 22791); 18 Aug 2007 00:56:41 -0000 X-Spam-Check-By: sourceware.org Received: from hq.tensilica.com (HELO mailapp.tensilica.com) (65.205.227.29) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 18 Aug 2007 00:56:37 +0000 Received: from localhost ([127.0.0.1]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1IMCcE-0006JH-TK; Fri, 17 Aug 2007 17:56:35 -0700 Received: from mailapp.tensilica.com ([127.0.0.1]) by localhost (mailapp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 23563-09; Fri, 17 Aug 2007 17:56:34 -0700 (PDT) Received: from maxim_fc5.hq.tensilica.com ([192.168.11.68]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1IMCcE-0006JC-I6; Fri, 17 Aug 2007 17:56:34 -0700 Message-ID: <46C643C2.4000405@hq.tensilica.com> Date: Sat, 18 Aug 2007 00:56:00 -0000 From: Maxim Grigoriev User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sources.redhat.com Subject: Re: [commit] Adding support for Xtensa Call0 ABI References: <46C6190A.2000007@hq.tensilica.com> <20070818002156.GA24165@adacore.com> In-Reply-To: <20070818002156.GA24165@adacore.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00351.txt.bz2 Joel Brobecker wrote: >> Since adding new ABI support is a big patch I considered >> that as a good opportunity to reformat comments >> (capitals, spaces after periods, etc) and do some >> minor clean-ups to match coding standard. >> > > Actually, it's cleaner if you could separate the formatting-only > patch from the real change. The formatting changes just clutter > your patch, and make it harder for us to review your changes. > I was thinking clean-ups are pretty straight forward. I got your point for the future and will separate patches covering different issues. I'm sorry for any inconvenience. > Is this worth a NEWS entry? > Well, I don't feel like it is. In the near future, I plan to submit Xtensa GNU Linux support introducing new target. That would be a true addition to the NEWS and good opportunity to mention that FSF Xtensa GDB supports both ABIs. -- Maxim