[gdbserver] SO_KEEPALIVE is being set on wrong socket.

[gdbserver] SO_KEEPALIVE is being set on wrong socket.

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 89 bytes --]

Hi,

I noticed that SO_KEEPALIVE is being set on the wrong socket.

Cheers,
Pedro Alves


[-- Attachment #2: keep_alive.diff --]
[-- Type: text/x-diff, Size: 894 bytes --]

2007-07-08  Pedro Alves  <pedro_alves@portugalmail.pt>

	* remote-utils.c (remote_open): Set SO_KEEPALIVE on remote_desc
	instead of on tmp_desc.

---
 gdb/gdbserver/remote-utils.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: src/gdb/gdbserver/remote-utils.c
===================================================================
--- src.orig/gdb/gdbserver/remote-utils.c	2007-07-07 10:54:48.000000000 +0100
+++ src/gdb/gdbserver/remote-utils.c	2007-07-07 10:55:58.000000000 +0100
@@ -246,7 +246,8 @@ remote_open (char *name)
 
       /* Enable TCP keep alive process. */
       tmp = 1;
-      setsockopt (tmp_desc, SOL_SOCKET, SO_KEEPALIVE, (char *) &tmp, sizeof (tmp));
+      setsockopt (remote_desc, SOL_SOCKET, SO_KEEPALIVE,
+		  (char *) &tmp, sizeof (tmp));
 
       /* Tell TCP not to delay small packets.  This greatly speeds up
          interactive response. */

Re: [gdbserver] SO_KEEPALIVE is being set on wrong socket.

[Daniel Jacobowitz]

On Sun, Jul 08, 2007 at 02:17:28AM +0100, Pedro Alves wrote:
> Hi,
> 
> I noticed that SO_KEEPALIVE is being set on the wrong socket.

Whooops!  Could you check this in, please?

-- 
Daniel Jacobowitz
CodeSourcery

Re: [gdbserver] SO_KEEPALIVE is being set on wrong socket.

[Pedro Alves]

Daniel Jacobowitz escreveu:
> On Sun, Jul 08, 2007 at 02:17:28AM +0100, Pedro Alves wrote:
>> Hi,
>>
>> I noticed that SO_KEEPALIVE is being set on the wrong socket.
> 
> Whooops!  Could you check this in, please?
> 

Done.

Cheers,
Pedro Alves