From: Denis PILAT <denis.pilat@st.com>
To: Denis PILAT <denis.pilat@st.com>,
Andrew STUBBS <andrew.stubbs@st.com>,
gdb-patches <gdb-patches@sourceware.org>,
Ilko Iliev <iliev@ronetix.at>
Subject: Re: [rfc] Overflow in transfer-rate
Date: Mon, 02 Jul 2007 07:36:00 -0000 [thread overview]
Message-ID: <4688AACA.70604@st.com> (raw)
In-Reply-To: <20070701221010.GA30560@caradoc.them.org>
Daniel Jacobowitz wrote:
> On Mon, Jun 11, 2007 at 03:15:41PM +0200, Denis PILAT wrote:
>
>> Andrew STUBBS wrote:
>>
>>> Denis PILAT wrote:
>>>
>>>> In symfile.c/print_transfer_performance (), an overflow can occure when
>>>> data_count (see below) is a large number.
>>>>
>>>> I propose either the following 1st patch, or to pass to "%llu"into the
>>>> ui_out_field_fmt functino call, see the next patch proposal.
>>>>
>>> I might also be worth taking a look at this proposal from some time ago
>>> http://www.cygwin.com/ml/gdb-patches/2006-10/msg00184.html
>>>
>>>
>> Well, it sounds like an internal ST discussion but I prefer the patch in your
>> link, it avoids overflow *and* prints transfer rate in a much clever way.
>>
>
> How about this version, then? I left GDB/MI behavior unchanged, so
> that this does not break GUIs.
>
>
Hi Daniel,
You're right, we must not break MI based GUI, I'm fine with your proposal.
I guess it will be include in 6.8 , not 6.7 GDB version ?
Thanks,
Denis
next prev parent reply other threads:[~2007-07-02 7:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 12:05 Denis PILAT
2007-06-11 12:52 ` Andrew STUBBS
2007-06-11 13:15 ` Denis PILAT
2007-07-01 22:10 ` Daniel Jacobowitz
2007-07-02 7:36 ` Denis PILAT [this message]
2007-07-03 15:32 ` Daniel Jacobowitz
2007-07-04 17:19 ` Joel Brobecker
2007-07-04 18:00 ` Mark Kettenis
2007-07-04 18:15 ` Daniel Jacobowitz
2007-07-04 18:20 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4688AACA.70604@st.com \
--to=denis.pilat@st.com \
--cc=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
--cc=iliev@ronetix.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox