From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25108 invoked by alias); 2 Jul 2007 07:36:07 -0000 Received: (qmail 25099 invoked by uid 22791); 2 Jul 2007 07:36:06 -0000 X-Spam-Check-By: sourceware.org Received: from s200aog11.obsmtp.com (HELO s200aog11.obsmtp.com) (207.126.144.125) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 02 Jul 2007 07:36:01 +0000 Received: from source ([164.129.1.35]) (using TLSv1) by eu1sys200aob011.postini.com ([207.126.147.11]) with SMTP; Mon, 02 Jul 2007 07:35:49 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D5C96DA94; Mon, 2 Jul 2007 07:35:40 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6AFC74BE79; Mon, 2 Jul 2007 07:35:40 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKY39396 (AUTH "denis pilat"); Mon, 2 Jul 2007 09:35:38 +0200 (CEST) Message-ID: <4688AACA.70604@st.com> Date: Mon, 02 Jul 2007 07:36:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.12 (X11/20070509) MIME-Version: 1.0 To: Denis PILAT , Andrew STUBBS , gdb-patches , Ilko Iliev Subject: Re: [rfc] Overflow in transfer-rate References: <466D3A7D.9030101@st.com> <466D456F.5070406@st.com> <466D4AFD.8070409@st.com> <20070701221010.GA30560@caradoc.them.org> In-Reply-To: <20070701221010.GA30560@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00029.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Jun 11, 2007 at 03:15:41PM +0200, Denis PILAT wrote: > >> Andrew STUBBS wrote: >> >>> Denis PILAT wrote: >>> >>>> In symfile.c/print_transfer_performance (), an overflow can occure when >>>> data_count (see below) is a large number. >>>> >>>> I propose either the following 1st patch, or to pass to "%llu"into the >>>> ui_out_field_fmt functino call, see the next patch proposal. >>>> >>> I might also be worth taking a look at this proposal from some time ago >>> http://www.cygwin.com/ml/gdb-patches/2006-10/msg00184.html >>> >>> >> Well, it sounds like an internal ST discussion but I prefer the patch in your >> link, it avoids overflow *and* prints transfer rate in a much clever way. >> > > How about this version, then? I left GDB/MI behavior unchanged, so > that this does not break GUIs. > > Hi Daniel, You're right, we must not break MI based GUI, I'm fine with your proposal. I guess it will be include in 6.8 , not 6.7 GDB version ? Thanks, Denis