From: Markus Deuling <deuling@de.ibm.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [rfc] Remove macros {SP,PC,PS,FP0}_REGNUM from gdbarch.sh
Date: Wed, 13 Jun 2007 17:49:00 -0000 [thread overview]
Message-ID: <46702DE1.6020103@de.ibm.com> (raw)
In-Reply-To: <ups3ziwuu.fsf@gnu.org>
Eli Zaretskii wrote:
>> Date: Wed, 13 Jun 2007 15:17:23 +0200
>> From: Markus Deuling <deuling@de.ibm.com>
>> CC: Ulrich Weigand <uweigand@de.ibm.com>
>>
>> this patch removes following macros from gdbarch.sh:
>>
>> * SP_REGNUM
>> * PC_REGNUM
>> * PS_REGNUM
>> * FP0_REGNUM
>
> You do this in go32-nat.c, which I think will break the DJGPP port,
> because AFAIK it doesn't support gdbarch.
>
Hm, the only of these 4 macros used in g032-nat.c is FP0_REGNUM. I don't see any
other definition of FP0_REGNUM beside the one in gdbarch.h
#if !defined (GDB_TM_FILE) && defined (FP0_REGNUM)
#error "Non multi-arch definition of FP0_REGNUM"
#endif
#if !defined (FP0_REGNUM)
#define FP0_REGNUM (gdbarch_fp0_regnum (current_gdbarch))
#endif
So go32-nat.c uses gdbarch_fp0_regnum, doesn't it? What am I overseeing?
Thank you very much for your review.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
next prev parent reply other threads:[~2007-06-13 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 13:19 Markus Deuling
2007-06-13 17:32 ` Eli Zaretskii
2007-06-13 17:39 ` Daniel Jacobowitz
2007-06-13 17:55 ` Eli Zaretskii
2007-06-13 17:49 ` Markus Deuling [this message]
2007-06-13 17:57 ` Eli Zaretskii
2007-06-18 6:47 Markus Deuling
2007-06-18 17:48 ` Ulrich Weigand
2007-06-19 3:27 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46702DE1.6020103@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox