From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31568 invoked by alias); 13 Jun 2007 17:49:50 -0000 Received: (qmail 31560 invoked by uid 22791); 13 Jun 2007 17:49:50 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Jun 2007 17:49:43 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5DHndWj194706 for ; Wed, 13 Jun 2007 17:49:39 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5DHndsn4096254 for ; Wed, 13 Jun 2007 19:49:39 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5DHndfj018608 for ; Wed, 13 Jun 2007 19:49:39 +0200 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l5DHnc73018598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Jun 2007 19:49:39 +0200 Message-ID: <46702DE1.6020103@de.ibm.com> Date: Wed, 13 Jun 2007 17:49:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org, uweigand@de.ibm.com Subject: Re: [rfc] Remove macros {SP,PC,PS,FP0}_REGNUM from gdbarch.sh References: <466FEE63.7010302@de.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00250.txt.bz2 Eli Zaretskii wrote: >> Date: Wed, 13 Jun 2007 15:17:23 +0200 >> From: Markus Deuling >> CC: Ulrich Weigand >> >> this patch removes following macros from gdbarch.sh: >> >> * SP_REGNUM >> * PC_REGNUM >> * PS_REGNUM >> * FP0_REGNUM > > You do this in go32-nat.c, which I think will break the DJGPP port, > because AFAIK it doesn't support gdbarch. > Hm, the only of these 4 macros used in g032-nat.c is FP0_REGNUM. I don't see any other definition of FP0_REGNUM beside the one in gdbarch.h #if !defined (GDB_TM_FILE) && defined (FP0_REGNUM) #error "Non multi-arch definition of FP0_REGNUM" #endif #if !defined (FP0_REGNUM) #define FP0_REGNUM (gdbarch_fp0_regnum (current_gdbarch)) #endif So go32-nat.c uses gdbarch_fp0_regnum, doesn't it? What am I overseeing? Thank you very much for your review. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com