From: Markus Deuling <deuling@de.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [rfc] [2/2] Remove macros TARGET_{FLOAT,DOUBLE,LONG_DOUBLE}_{BIT|FORMAT}
Date: Tue, 12 Jun 2007 16:39:00 -0000 [thread overview]
Message-ID: <466ECBF6.2020205@de.ibm.com> (raw)
In-Reply-To: <200706121637.l5CGb6wK031866@d12av02.megacenter.de.ibm.com>
Ulrich Weigand wrote:
> Markus Deuling wrote:
>
>> Sorry. Attached is a rebased version that applies against current head :-)
>
> Thanks. One more thing: I've found an inconsistency in the gdbarch.c /
> gdbarch.sh changes:
>
>> diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c
>> --- src/gdb/gdbarch.c 2007-06-12 18:05:43.000000000 +0200
>> +++ dev/gdb/gdbarch.c 2007-06-12 18:07:23.000000000 +0200
>> @@ -373,7 +373,7 @@
>> struct gdbarch_tdep *tdep)
>> {
>> /* NOTE: The new architecture variable is named ``current_gdbarch''
>> - so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to
>> + so that macros such as TARGET_ARCHITECTURE, when expanded, refer to
>> the current local architecture and not the previous global
>> architecture. This ensures that the new architectures initial
>> values are not influenced by the previous architecture. Once
>
>> diff -urN src/gdb/gdbarch.sh dev/gdb/gdbarch.sh
>> --- src/gdb/gdbarch.sh 2007-06-12 18:05:43.000000000 +0200
>> +++ dev/gdb/gdbarch.sh 2007-06-12 18:07:23.000000000 +0200
>> @@ -1348,7 +1348,7 @@
>> struct gdbarch_tdep *tdep)
>> {
>> /* NOTE: The new architecture variable is named \`\`current_gdbarch''
>> - so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to
>> + so that macros such as gdbarch_double_bit, when expanded, refer to
>> the current local architecture and not the previous global
>> architecture. This ensures that the new architectures initial
>> values are not influenced by the previous architecture. Once
>
> I've now committed the patch with this fixed.
>
> Bye,
> Ulrich
>
Again, thank you very much :-)
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
prev parent reply other threads:[~2007-06-12 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 10:26 Markus Deuling
2007-06-12 14:17 ` Ulrich Weigand
2007-06-12 14:47 ` Markus Deuling
2007-06-12 15:39 ` Ulrich Weigand
2007-06-12 16:15 ` Markus Deuling
2007-06-12 16:37 ` Ulrich Weigand
2007-06-12 16:39 ` Markus Deuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466ECBF6.2020205@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox