From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16630 invoked by alias); 12 Jun 2007 16:39:43 -0000 Received: (qmail 16616 invoked by uid 22791); 12 Jun 2007 16:39:43 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 16:39:39 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5CGdaws087370 for ; Tue, 12 Jun 2007 16:39:36 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5CGdalM4124788 for ; Tue, 12 Jun 2007 18:39:36 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5CGdarg001188 for ; Tue, 12 Jun 2007 18:39:36 +0200 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l5CGdZHG001173 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Jun 2007 18:39:35 +0200 Message-ID: <466ECBF6.2020205@de.ibm.com> Date: Tue, 12 Jun 2007 16:39:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Ulrich Weigand CC: GDB Patches Subject: Re: [rfc] [2/2] Remove macros TARGET_{FLOAT,DOUBLE,LONG_DOUBLE}_{BIT|FORMAT} References: <200706121637.l5CGb6wK031866@d12av02.megacenter.de.ibm.com> In-Reply-To: <200706121637.l5CGb6wK031866@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00201.txt.bz2 Ulrich Weigand wrote: > Markus Deuling wrote: > >> Sorry. Attached is a rebased version that applies against current head :-) > > Thanks. One more thing: I've found an inconsistency in the gdbarch.c / > gdbarch.sh changes: > >> diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c >> --- src/gdb/gdbarch.c 2007-06-12 18:05:43.000000000 +0200 >> +++ dev/gdb/gdbarch.c 2007-06-12 18:07:23.000000000 +0200 >> @@ -373,7 +373,7 @@ >> struct gdbarch_tdep *tdep) >> { >> /* NOTE: The new architecture variable is named ``current_gdbarch'' >> - so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to >> + so that macros such as TARGET_ARCHITECTURE, when expanded, refer to >> the current local architecture and not the previous global >> architecture. This ensures that the new architectures initial >> values are not influenced by the previous architecture. Once > >> diff -urN src/gdb/gdbarch.sh dev/gdb/gdbarch.sh >> --- src/gdb/gdbarch.sh 2007-06-12 18:05:43.000000000 +0200 >> +++ dev/gdb/gdbarch.sh 2007-06-12 18:07:23.000000000 +0200 >> @@ -1348,7 +1348,7 @@ >> struct gdbarch_tdep *tdep) >> { >> /* NOTE: The new architecture variable is named \`\`current_gdbarch'' >> - so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to >> + so that macros such as gdbarch_double_bit, when expanded, refer to >> the current local architecture and not the previous global >> architecture. This ensures that the new architectures initial >> values are not influenced by the previous architecture. Once > > I've now committed the patch with this fixed. > > Bye, > Ulrich > Again, thank you very much :-) -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com