Re: [RFC] DW_AT_type missing from DW_TAG_subrange_type

[Denis PILAT <denis.pilat@st.com>]

Daniel Jacobowitz wrote:
> On Wed, Apr 18, 2007 at 03:06:38PM +0200, Denis PILAT wrote:
>   
>> Ok, that means I did a mistake in my previous ChangeLog entry about 
>> target_terminal_ours ?
>> Can I change it as well in the same commit, removing "()" ?
>>     
>
> Yes please.
>
>   
Just committed.

-- 
Denis

2007-04-18  Denis Pilat  <denis.pilat@st.com>

	* dwarf2read.c (read_subrange_type): Use DW_ATE_signed default type
	when missing from DW_TAG_subrange_type.  Remove the handling of null
	return from die_type.

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.217
retrieving revision 1.218
diff -u -p -r1.217 -r1.218
--- dwarf2read.c        11 Apr 2007 16:04:22 -0000      1.217
+++ dwarf2read.c        18 Apr 2007 13:25:04 -0000      1.218
@@ -4914,16 +4914,13 @@ read_subrange_type (struct die_info *die
     return;

   base_type = die_type (die, cu);
-  if (base_type == NULL)
+  if (TYPE_CODE (base_type) == TYPE_CODE_VOID)
     {
       complaint (&symfile_complaints,
                 _("DW_AT_type missing from DW_TAG_subrange_type"));
-      return;
+      base_type = dwarf_base_type (DW_ATE_signed, TARGET_ADDR_BIT / 8, cu);
     }

-  if (TYPE_CODE (base_type) == TYPE_CODE_VOID)
-    base_type = alloc_type (NULL);
-
   if (cu->language == language_fortran)
     {
       /* FORTRAN implies a lower bound of 1, if not given.  */