From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10152 invoked by alias); 18 Apr 2007 13:30:22 -0000 Received: (qmail 10143 invoked by uid 22791); 18 Apr 2007 13:30:21 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-04.spheriq.net (HELO lon-del-04.spheriq.net) (195.46.50.101) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Apr 2007 14:30:15 +0100 Received: from lon-out-02.spheriq.net ([195.46.50.130]) by lon-del-04.spheriq.net with ESMTP id l3IDUCwm030092 for ; Wed, 18 Apr 2007 13:30:12 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-02.spheriq.net with ESMTP id l3IDUBU7023666 for ; Wed, 18 Apr 2007 13:30:11 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id l3IDTvbV009148 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK) for ; Wed, 18 Apr 2007 13:30:04 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3E40EDA4E for ; Wed, 18 Apr 2007 13:29:50 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EE72C4748A for ; Wed, 18 Apr 2007 13:29:49 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKG61110 (AUTH "denis pilat"); Wed, 18 Apr 2007 15:29:49 +0200 (CEST) Message-ID: <46261D4D.7010505@st.com> Date: Wed, 18 Apr 2007 14:21:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: Denis PILAT , gdb-patches@sourceware.org Subject: Re: [RFC] DW_AT_type missing from DW_TAG_subrange_type References: <4612556C.1080709@st.com> <20070410153043.GC10890@caradoc.them.org> <46261453.1050102@st.com> <20070418130059.GA22170@caradoc.them.org> <462617DE.907@st.com> <20070418131700.GA23905@caradoc.them.org> In-Reply-To: <20070418131700.GA23905@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00285.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Apr 18, 2007 at 03:06:38PM +0200, Denis PILAT wrote: > >> Ok, that means I did a mistake in my previous ChangeLog entry about >> target_terminal_ours ? >> Can I change it as well in the same commit, removing "()" ? >> > > Yes please. > > Just committed. -- Denis 2007-04-18 Denis Pilat * dwarf2read.c (read_subrange_type): Use DW_ATE_signed default type when missing from DW_TAG_subrange_type. Remove the handling of null return from die_type. Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.217 retrieving revision 1.218 diff -u -p -r1.217 -r1.218 --- dwarf2read.c 11 Apr 2007 16:04:22 -0000 1.217 +++ dwarf2read.c 18 Apr 2007 13:25:04 -0000 1.218 @@ -4914,16 +4914,13 @@ read_subrange_type (struct die_info *die return; base_type = die_type (die, cu); - if (base_type == NULL) + if (TYPE_CODE (base_type) == TYPE_CODE_VOID) { complaint (&symfile_complaints, _("DW_AT_type missing from DW_TAG_subrange_type")); - return; + base_type = dwarf_base_type (DW_ATE_signed, TARGET_ADDR_BIT / 8, cu); } - if (TYPE_CODE (base_type) == TYPE_CODE_VOID) - base_type = alloc_type (NULL); - if (cu->language == language_fortran) { /* FORTRAN implies a lower bound of 1, if not given. */