Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Brian Dessent <brian@dessent.net>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	drow@false.org,  	gdb-patches@sources.redhat.com,
	insight@sourceware.org
Subject: [patch] fix insight (was: Re: Ping: frozen variable objects)
Date: Wed, 18 Apr 2007 10:22:00 -0000	[thread overview]
Message-ID: <4625EB96.73C48E8C@dessent.net> (raw)
In-Reply-To: <200704141353.51962.vladimir@codesourcery.com>

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Vladimir Prus wrote:

> Here's what I've just checked in. There was already -var-update anchor, but
> it was on the list of varobj attributes, so I've renamed it, and added -var-update
> anchor at the top of -var-update description.

This has unfortunately broken insight, which had one caller of
varobj_update lurking in gdbtk/generic/gdbtk-varobj.c that now fails due
to the extra paremeter.  Fix attached.

Brian

[-- Attachment #2: insight_varobj_update.patch --]
[-- Type: text/plain, Size: 863 bytes --]

2007-04-18  Brian Dessent  <brian@dessent.net>

	* generic/gdbtk-varobj.c (variable_update): Add explicit parameter
	to varobj_update.

Index: generic/gdbtk-varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-varobj.c,v
retrieving revision 1.19
diff -u -p -r1.19 gdbtk-varobj.c
--- generic/gdbtk-varobj.c	23 Dec 2005 18:23:16 -0000	1.19
+++ generic/gdbtk-varobj.c	18 Apr 2007 09:51:38 -0000
@@ -447,7 +447,7 @@ variable_update (Tcl_Interp *interp, str
 
   /* varobj_update() can return -1 if the variable is no longer around,
      i.e. we stepped out of the frame in which a local existed. */
-  if (varobj_update (var, &changelist) == -1)
+  if (varobj_update (var, &changelist, 1 /* explicit */) == -1)
     return Tcl_NewStringObj ("-1", -1);
 
   changed = Tcl_NewListObj (0, NULL);  

  parent reply	other threads:[~2007-04-18  9:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-25  9:52 Ping: frozen variable objects Vladimir Prus
2007-03-25 20:17 ` Eli Zaretskii
2007-04-10 19:03 ` Daniel Jacobowitz
2007-04-11 14:44   ` Vladimir Prus
2007-04-11 14:52     ` Daniel Jacobowitz
2007-04-11 18:38       ` Eli Zaretskii
2007-04-13  9:53     ` Eli Zaretskii
2007-04-14 16:14       ` Vladimir Prus
2007-04-14 16:19         ` Daniel Jacobowitz
2007-04-14 23:18           ` Nick Roberts
2007-04-15 10:32             ` Vladimir Prus
2007-04-15 10:35             ` Vladimir Prus
2007-04-15 11:46               ` Nick Roberts
2007-04-15 11:57                 ` Vladimir Prus
2007-04-15 20:09                   ` Nick Roberts
2007-04-15 20:16                   ` Eli Zaretskii
2007-04-15 20:13               ` Eli Zaretskii
2007-04-14 20:32         ` Eli Zaretskii
2007-04-15 11:42           ` Vladimir Prus
2007-04-15 12:03             ` Nick Roberts
2007-04-16  2:40               ` Eli Zaretskii
2007-04-18  5:38                 ` Vladimir Prus
2007-04-18 10:37                   ` Nick Roberts
2007-04-18 22:23                     ` Eli Zaretskii
2007-04-19  4:41                   ` Eli Zaretskii
2007-04-15 20:14             ` Eli Zaretskii
2007-04-15  8:04         ` Nick Roberts
2007-04-18 10:22         ` Brian Dessent [this message]
2007-04-18 12:51           ` [patch] fix insight (was: Re: Ping: frozen variable objects) Maciej W. Rozycki
2007-04-18 13:01             ` Brian Dessent
2007-04-18  5:38   ` Ping: frozen variable objects Michael Snyder
2007-04-18  6:57     ` Vladimir Prus
2007-04-18 22:21       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4625EB96.73C48E8C@dessent.net \
    --to=brian@dessent.net \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=insight@sourceware.org \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox