From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19281 invoked by alias); 18 Apr 2007 09:59:17 -0000 Received: (qmail 19267 invoked by uid 22791); 18 Apr 2007 09:59:17 -0000 X-Spam-Check-By: sourceware.org Received: from dessent.net (HELO dessent.net) (69.60.119.225) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Apr 2007 10:59:15 +0100 Received: from localhost ([127.0.0.1] helo=dessent.net) by dessent.net with esmtp (Exim 4.50) id 1He6wH-00064L-Kz; Wed, 18 Apr 2007 09:59:02 +0000 Message-ID: <4625EB96.73C48E8C@dessent.net> Date: Wed, 18 Apr 2007 10:22:00 -0000 From: Brian Dessent Reply-To: gdb-patches@sources.redhat.com X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) MIME-Version: 1.0 To: Vladimir Prus CC: Eli Zaretskii , drow@false.org, gdb-patches@sources.redhat.com, insight@sourceware.org Subject: [patch] fix insight (was: Re: Ping: frozen variable objects) References: <200703251351.43195.vladimir@codesourcery.com> <200704111843.43991.vladimir@codesourcery.com> <200704141353.51962.vladimir@codesourcery.com> Content-Type: multipart/mixed; boundary="------------DE40EC51951B1D87DC2891FE" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00277.txt.bz2 This is a multi-part message in MIME format. --------------DE40EC51951B1D87DC2891FE Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-length: 415 Vladimir Prus wrote: > Here's what I've just checked in. There was already -var-update anchor, but > it was on the list of varobj attributes, so I've renamed it, and added -var-update > anchor at the top of -var-update description. This has unfortunately broken insight, which had one caller of varobj_update lurking in gdbtk/generic/gdbtk-varobj.c that now fails due to the extra paremeter. Fix attached. Brian --------------DE40EC51951B1D87DC2891FE Content-Type: text/plain; charset=us-ascii; name="insight_varobj_update.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="insight_varobj_update.patch" Content-length: 863 2007-04-18 Brian Dessent * generic/gdbtk-varobj.c (variable_update): Add explicit parameter to varobj_update. Index: generic/gdbtk-varobj.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-varobj.c,v retrieving revision 1.19 diff -u -p -r1.19 gdbtk-varobj.c --- generic/gdbtk-varobj.c 23 Dec 2005 18:23:16 -0000 1.19 +++ generic/gdbtk-varobj.c 18 Apr 2007 09:51:38 -0000 @@ -447,7 +447,7 @@ variable_update (Tcl_Interp *interp, str /* varobj_update() can return -1 if the variable is no longer around, i.e. we stepped out of the frame in which a local existed. */ - if (varobj_update (var, &changelist) == -1) + if (varobj_update (var, &changelist, 1 /* explicit */) == -1) return Tcl_NewStringObj ("-1", -1); changed = Tcl_NewListObj (0, NULL); --------------DE40EC51951B1D87DC2891FE--