From: Denis PILAT <denis.pilat@st.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] re-initialize height to 0 during setshow.exp
Date: Tue, 03 Apr 2007 13:26:00 -0000 [thread overview]
Message-ID: <46125608.50800@st.com> (raw)
In-Reply-To: <1175536591.9195.12.camel@svmsnyderlnx.palmsource.com>
Michael Snyder wrote:
> On Mon, 2007-04-02 at 16:57 +0200, Denis PILAT wrote:
>
>> In testsuite/gdb.base/setshow.exp, after "set height 100", it could
>> occur that following commands require user interaction to proceed like:
>> ---Type <return> to continue, or q <return> to quit---
>> (At least it's the case for our gdb in "show user" since we have defined
>> a lot of user command.)
>>
>> Attach is a patch that fixes a problem in this test.
>> We could also add
>> gdb_test "set height 0" "" "set height 0"
>> or increase the height to a very large number, but I prefer to reset
>> height to 0 like done in gdb.exp.
>>
>>
>
> I think it's valid, but I wonder why you didn't just use gdb_test,
> instead of gdb_expect? Are you expecting the command to fail or
> time out or something?
>
>
>
It just because gdb_test will add a new test, and I just want to fix a
problem.
But it would be much simpler to add *gdb_test "set height 0" "" "set
height 0"*
It was much RFC I should I put in my title,
Any more opinion ?
--
Denis
next prev parent reply other threads:[~2007-04-03 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 14:57 Denis PILAT
2007-04-02 17:56 ` Michael Snyder
2007-04-03 13:26 ` Denis PILAT [this message]
2007-04-03 14:34 ` Daniel Jacobowitz
2007-04-03 14:53 ` Denis PILAT
2007-04-10 15:14 ` Daniel Jacobowitz
2007-04-16 13:50 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46125608.50800@st.com \
--to=denis.pilat@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox