From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18976 invoked by alias); 3 Apr 2007 13:26:52 -0000 Received: (qmail 18967 invoked by uid 22791); 3 Apr 2007 13:26:51 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-04.spheriq.net (HELO lon-del-04.spheriq.net) (195.46.50.101) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 03 Apr 2007 14:26:43 +0100 Received: from lon-out-02.spheriq.net ([195.46.50.130]) by lon-del-04.spheriq.net with ESMTP id l33DQfqZ031574 for ; Tue, 3 Apr 2007 13:26:41 GMT Received: from lon-cus-02.spheriq.net (lon-cus-02.spheriq.net [195.46.50.38]) by lon-out-02.spheriq.net with ESMTP id l33DQcmN027625 for ; Tue, 3 Apr 2007 13:26:38 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-02.spheriq.net with ESMTP id l33DQZru016854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Apr 2007 13:26:37 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 67DAFDA48 for ; Tue, 3 Apr 2007 13:26:34 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0410F474F3 for ; Tue, 3 Apr 2007 13:26:33 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKD60785 (AUTH "denis pilat"); Tue, 3 Apr 2007 15:26:33 +0200 (CEST) Message-ID: <46125608.50800@st.com> Date: Tue, 03 Apr 2007 13:26:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: gdb-patches Subject: Re: [RFA] re-initialize height to 0 during setshow.exp References: <461119CA.6060509@st.com> <1175536591.9195.12.camel@svmsnyderlnx.palmsource.com> In-Reply-To: <1175536591.9195.12.camel@svmsnyderlnx.palmsource.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00015.txt.bz2 Michael Snyder wrote: > On Mon, 2007-04-02 at 16:57 +0200, Denis PILAT wrote: > >> In testsuite/gdb.base/setshow.exp, after "set height 100", it could >> occur that following commands require user interaction to proceed like: >> ---Type to continue, or q to quit--- >> (At least it's the case for our gdb in "show user" since we have defined >> a lot of user command.) >> >> Attach is a patch that fixes a problem in this test. >> We could also add >> gdb_test "set height 0" "" "set height 0" >> or increase the height to a very large number, but I prefer to reset >> height to 0 like done in gdb.exp. >> >> > > I think it's valid, but I wonder why you didn't just use gdb_test, > instead of gdb_expect? Are you expecting the command to fail or > time out or something? > > > It just because gdb_test will add a new test, and I just want to fix a problem. But it would be much simpler to add *gdb_test "set height 0" "" "set height 0"* It was much RFC I should I put in my title, Any more opinion ? -- Denis