From: Denis PILAT <denis.pilat@st.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org
Subject: Re: [RFC] -thread-select double print stack frame
Date: Wed, 28 Mar 2007 08:26:00 -0000 [thread overview]
Message-ID: <460A2681.30700@st.com> (raw)
In-Reply-To: <17930.715.767042.438147@farnswood.snap.net.nz>
>
> > This does make me wonder about the patch though. Denis, could you
> > hold off on committing it? Which duplicate copy are you eliminating?
> > Maybe we should diff two testsuite runs to see what else changes.
>
> No, I think this change is alright (I haven't run the testsuite though.).
>
I do run the testsuite on i386-linux native target, no regression at all.
Can I commit or not ?
> It's your decision but the next release is a long way off and if these changes
> are not the right ones they are not far off. So I would suggest committing
> them all i.e this one, yours and Denis's -thread-* commands now. That way
> if there are problems we will quite likely discover them before the release.
>
I will modify my patch on -thread-info new command once Daniel has
committed.
I'll try to write a doc entry as well ...
--
Denis
next prev parent reply other threads:[~2007-03-28 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 13:48 Denis PILAT
2007-03-20 0:57 ` Nick Roberts
2007-03-26 13:19 ` Denis PILAT
2007-03-27 19:33 ` Daniel Jacobowitz
2007-03-27 21:42 ` Nick Roberts
2007-03-28 2:11 ` Daniel Jacobowitz
2007-03-28 5:56 ` Nick Roberts
2007-03-28 8:26 ` Denis PILAT [this message]
2007-03-28 11:43 ` Daniel Jacobowitz
2007-03-29 7:45 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460A2681.30700@st.com \
--to=denis.pilat@st.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox