From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23231 invoked by alias); 28 Mar 2007 08:26:05 -0000 Received: (qmail 23220 invoked by uid 22791); 28 Mar 2007 08:26:05 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-03.spheriq.net (HELO lon-del-03.spheriq.net) (195.46.50.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Mar 2007 09:26:01 +0100 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-03.spheriq.net with ESMTP id l2S8PxF2001601 for ; Wed, 28 Mar 2007 08:25:59 GMT Received: from lon-cus-02.spheriq.net (lon-cus-02.spheriq.net [195.46.50.38]) by lon-out-03.spheriq.net with ESMTP id l2S8Pvox014699 for ; Wed, 28 Mar 2007 08:25:58 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-02.spheriq.net with ESMTP id l2S8PrWJ022142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Mar 2007 08:25:56 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 28FC7DA48; Wed, 28 Mar 2007 08:25:42 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B88D5472A3; Wed, 28 Mar 2007 08:25:41 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CKC39633 (AUTH "denis pilat"); Wed, 28 Mar 2007 10:25:37 +0200 (CEST) Message-ID: <460A2681.30700@st.com> Date: Wed, 28 Mar 2007 08:26:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: Nick Roberts Cc: Daniel Jacobowitz , gdb-patches@sourceware.org Subject: Re: [RFC] -thread-select double print stack frame References: <45FE948B.9090007@st.com> <17919.12645.81319.568064@kahikatea.snap.net.nz> <4607C863.7080405@st.com> <20070327193257.GM28164@caradoc.them.org> <17929.36634.510715.364996@farnswood.snap.net.nz> <20070328021123.GA28506@caradoc.them.org> <17930.715.767042.438147@farnswood.snap.net.nz> In-Reply-To: <17930.715.767042.438147@farnswood.snap.net.nz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00286.txt.bz2 > > > This does make me wonder about the patch though. Denis, could you > > hold off on committing it? Which duplicate copy are you eliminating? > > Maybe we should diff two testsuite runs to see what else changes. > > No, I think this change is alright (I haven't run the testsuite though.). > I do run the testsuite on i386-linux native target, no regression at all. Can I commit or not ? > It's your decision but the next release is a long way off and if these changes > are not the right ones they are not far off. So I would suggest committing > them all i.e this one, yours and Denis's -thread-* commands now. That way > if there are problems we will quite likely discover them before the release. > I will modify my patch on -thread-info new command once Daniel has committed. I'll try to write a doc entry as well ... -- Denis