Re: New ARI warning Wed Aug 29 01:57:16 UTC 2018

[Simon Marchi <simon.marchi@ericsson.com>]

On 2018-08-28 09:57 PM, GDB Administrator wrote:
>> gdb/csky-tdep.c:2234: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
> gdb/csky-tdep.c:2234:  set_gdbarch_read_pc (gdbarch, csky_read_pc);
> gdb/csky-tdep.c:2234:  set_gdbarch_read_pc (gdbarch, csky_read_pc);

I am not sure about this one.  At first, I thought it was just a name clash,
the test looking for the "read_pc" function and wrongfully finding this line.
However, the check does purposefully look for "set_gdbarch_read_pc":

 997 BEGIN { doc["read_pc"] = "\
 998 Replace READ_PC() with frame_pc_unwind; \
 999 at present the inferior function call code still uses this"
1000     category["read_pc"] = ari_deprecate
1001 }
1002 /(^|[^_[:alnum:]])read_pc[[:space:]]*\(/ || \
1003 /(^|[^_[:alnum:]])set_gdbarch_read_pc[[:space:]]*\(/ || \
1004 /(^|[^_[:alnum:]])TARGET_READ_PC[[:space:]]*\(/ {
1005     fail("read_pc")
1006 }

Is this gdbarch method really deprecated?

Simon