From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124077 invoked by alias); 29 Aug 2018 14:34:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124054 invoked by uid 89); 29 Aug 2018 14:34:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=BEGIN, 1004, 1003 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 14:34:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1535553239; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fr4pp+kQbhPt8wtLh1/E+yMeDzT3+uc5irKJ7Dr3b/4=; b=bkqdeDXIUZPReANbeXvdnVyYU2BUVO3s0886zA94t60ERNkiomqaMsaV11bQCzLw GxQXEdUOOIUdp8u29eUMSYdthjeebwg4zS/g/8SFsMhAVd4C3hAE52daNAxZr70y YsU9ICcIVH7kvErmoXjPYhdukukti+WzqiMXYjlFOdQ=; Received: from ESESSMB504.ericsson.se (Unknown_Domain [153.88.183.122]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 03.6E.22015.7DEA68B5; Wed, 29 Aug 2018 16:33:59 +0200 (CEST) Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 29 Aug 2018 16:33:58 +0200 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 29 Aug 2018 16:33:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WG7cR1hNpOyE3W9S6L5Wvt3+tgQpYF5rRjevmaIRMw4=; b=bae5MZBs/ZBjCYcyvwfKaGD8C8UeC6ahVKatzYCicd59gwB7PHXEfKGO4GFAfkjVSzPhxNUMLMSbTZEjdyStx/N+xguFtdDCHP4iWXa7lKYGFYV5cVffI8jtIUspbkEXZjor7V0mggAlU6ASLFC8qYCe7ew34Xkq9eV/Vivedxs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.188] (192.75.88.130) by DM6PR15MB2396.namprd15.prod.outlook.com (2603:10b6:5:8d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.16; Wed, 29 Aug 2018 14:33:55 +0000 Subject: Re: New ARI warning Wed Aug 29 01:57:16 UTC 2018 To: GDB Administrator , References: <20180829015716.GA50222@sourceware.org> From: Simon Marchi Message-ID: <4602ce95-8f1b-2064-61ca-c0b027d2b21b@ericsson.com> Date: Wed, 29 Aug 2018 14:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180829015716.GA50222@sourceware.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00736.txt.bz2 On 2018-08-28 09:57 PM, GDB Administrator wrote: >> gdb/csky-tdep.c:2234: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this > gdb/csky-tdep.c:2234: set_gdbarch_read_pc (gdbarch, csky_read_pc); > gdb/csky-tdep.c:2234: set_gdbarch_read_pc (gdbarch, csky_read_pc); I am not sure about this one. At first, I thought it was just a name clash, the test looking for the "read_pc" function and wrongfully finding this line. However, the check does purposefully look for "set_gdbarch_read_pc": 997 BEGIN { doc["read_pc"] = "\ 998 Replace READ_PC() with frame_pc_unwind; \ 999 at present the inferior function call code still uses this" 1000 category["read_pc"] = ari_deprecate 1001 } 1002 /(^|[^_[:alnum:]])read_pc[[:space:]]*\(/ || \ 1003 /(^|[^_[:alnum:]])set_gdbarch_read_pc[[:space:]]*\(/ || \ 1004 /(^|[^_[:alnum:]])TARGET_READ_PC[[:space:]]*\(/ { 1005 fail("read_pc") 1006 } Is this gdbarch method really deprecated? Simon