[RFC] TUI is broken in the cvs head

[RFC] TUI is broken in the cvs head

[Denis PILAT]

Attached is a simple patch that fixes a problem with the TUI: it was not 
possible anymore to load a binary file.
I saw that problem on a linux native debugger. The file command outputs 
"No registers." as an error message.

-- 

Denis

2007-03-05  Denis Pilat  <denis.pilat@st.com>


	* tui/tui-hooks.c (tui_selected_frame_level_changed_hook): Replace
	get_selected_frame by deprecated_safe_get_selected_frame.

Index: tui/tui-hooks.c

===================================================================

RCS file: /cvs/src/src/gdb/tui/tui-hooks.c,v

retrieving revision 1.29

diff -u -p -r1.29 tui-hooks.c

--- tui/tui-hooks.c     27 Feb 2007 19:46:04 -0000      1.29

+++ tui/tui-hooks.c     5 Mar 2007 17:24:39 -0000

@@ -230,7 +230,7 @@ tui_selected_frame_level_changed_hook (i

 {

   struct frame_info *fi;


-  fi = get_selected_frame (NULL);

+  fi = deprecated_safe_get_selected_frame ();

   /* Ensure that symbols for this frame are read in.  Also, determine the

      source language of this frame, and switch to it if desired.  */

   if (fi)

Re: [RFC] TUI is broken in the cvs head

[Daniel Jacobowitz]

On Mon, Mar 05, 2007 at 06:33:12PM +0100, Denis PILAT wrote:
> Attached is a simple patch that fixes a problem with the TUI: it was not 
> possible anymore to load a binary file.
> I saw that problem on a linux native debugger. The file command outputs 
> "No registers." as an error message.

Whoops.  OK thanks.  These hooks are a mess...

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFC] TUI is broken in the cvs head

[Denis PILAT]

Daniel Jacobowitz wrote:
> On Mon, Mar 05, 2007 at 06:33:12PM +0100, Denis PILAT wrote:
>   
>> Attached is a simple patch that fixes a problem with the TUI: it was not 
>> possible anymore to load a binary file.
>> I saw that problem on a linux native debugger. The file command outputs 
>> "No registers." as an error message.
>>     
>
> Whoops.  OK thanks.  These hooks are a mess...
>
>   
Committedthis morning. TUI works again!

Denis

Re: [RFC] TUI is broken in the cvs head

[Denis PILAT]

Denis PILAT wrote:
> Daniel Jacobowitz wrote:
>> On Mon, Mar 05, 2007 at 06:33:12PM +0100, Denis PILAT wrote:
>>  
>>> Attached is a simple patch that fixes a problem with the TUI: it was 
>>> not possible anymore to load a binary file.
>>> I saw that problem on a linux native debugger. The file command 
>>> outputs "No registers." as an error message.
>>>     
>>
>> Whoops.  OK thanks.  These hooks are a mess...
>>
>>   
> Committedthis morning. TUI works again!
>
> Denis
>
Hi Daniel,

It's good for linux hosts, but TUI still does not work for Solaris host !!!
When running it just exits.

Has anyone tried it for Solaris 8 ?
It does not seem to come from the xml support recently added.
I will work on fixing that tomorrow.

Denis