From: Andrew STUBBS <andrew.stubbs@st.com>
To: Andrew STUBBS <andrew.stubbs@st.com>,
GDB Patches <gdb-patches@sourceware.org>,
john.pye@anu.edu.au
Subject: Re: [PATCH] Ctrl-D
Date: Wed, 06 Dec 2006 16:54:00 -0000 [thread overview]
Message-ID: <4576F5CC.2000400@st.com> (raw)
In-Reply-To: <20061205205030.GD25572@nevyn.them.org>
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
Daniel Jacobowitz wrote:
> OK for HEAD with or without that change, as you prefer. I'd recommend
> this for 6.6 now that it's in HEAD; Joel, is that OK?
Committed to both HEAD and gdb_6_6-branch with the suggested change.
The final patch is attached.
Andrew
[-- Attachment #2: ctrl-d.patch --]
[-- Type: text/plain, Size: 1304 bytes --]
2006-12-06 Andrew Stubbs <andrew.stubbs@st.com>
* event-top.c (command_handler): On EOF, print 'quit' and run quit
command via execute_command such that hooks and trace work.
* utils.c (defaulted_query): On EOF, print default answer and newline.
Index: src/gdb/event-top.c
===================================================================
--- src.orig/gdb/event-top.c 2006-12-06 10:49:25.000000000 +0000
+++ src/gdb/event-top.c 2006-12-06 13:52:46.000000000 +0000
@@ -501,7 +501,10 @@ command_handler (char *command)
but GDB is still alive. In such a case, we just quit gdb
killing the inferior program too. */
if (command == 0)
- quit_command ((char *) 0, stdin == instream);
+ {
+ printf_unfiltered ("quit\n");
+ execute_command ("quit", stdin == instream);
+ }
time_at_cmd_start = get_run_time ();
Index: src/gdb/utils.c
===================================================================
--- src.orig/gdb/utils.c 2006-12-06 10:49:26.000000000 +0000
+++ src/gdb/utils.c 2006-12-06 13:54:01.000000000 +0000
@@ -1230,6 +1230,7 @@ defaulted_query (const char *ctlstr, con
clearerr (stdin); /* in case of C-d */
if (answer == EOF) /* C-d */
{
+ printf_filtered ("EOF [assumed %c]\n", def_answer);
retval = def_value;
break;
}
prev parent reply other threads:[~2006-12-06 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 13:10 Andrew STUBBS
2006-12-04 12:17 ` Andrew STUBBS
2006-12-05 4:28 ` Joel Brobecker
2006-12-05 20:50 ` Daniel Jacobowitz
2006-12-06 1:06 ` Joel Brobecker
2006-12-06 16:54 ` Andrew STUBBS [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4576F5CC.2000400@st.com \
--to=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
--cc=john.pye@anu.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox