Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Andrew STUBBS <andrew.stubbs@st.com>,
		GDB Patches <gdb-patches@sourceware.org>,
	john.pye@anu.edu.au
Subject: Re: [PATCH] Ctrl-D
Date: Wed, 06 Dec 2006 01:06:00 -0000	[thread overview]
Message-ID: <20061206010627.GE32651@adacore.com> (raw)
In-Reply-To: <20061205205030.GD25572@nevyn.them.org>

> > New behaviour:
> > 
> > (gdb) <C-d>quit
> > The program is running.  Exit anyway? (y or n) <C-d>Y
> > bash$
> 
> How'd you feel about "EOF [assumed %c]" or something like that?  I'd
> look at that and think I typed the Y.

I really like Daniel's suggestion.

> > 2006-11-30  Andrew Stubbs  <andrew.stubbs@st.com>
> > 
> > 	* event-top.c (command_handler): On EOF, print 'quit' and run quit
> > 	command via execute_command such that hooks and trace work.
> > 	* utils.c (defaulted_query): On EOF, print default answer and newline.
> 
> OK for HEAD with or without that change, as you prefer.  I'd recommend
> this for 6.6 now that it's in HEAD; Joel, is that OK?

Sure. I was a bit nervious about any unexpected side-effect of the change
in event-top.c (changing the call to quit_command() into a call to
execute_command ("quit")) But if you think it's low risk, then I don't
have any problem.

-- 
Joel


  reply	other threads:[~2006-12-06  1:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30 13:10 Andrew STUBBS
2006-12-04 12:17 ` Andrew STUBBS
2006-12-05  4:28   ` Joel Brobecker
2006-12-05 20:50 ` Daniel Jacobowitz
2006-12-06  1:06   ` Joel Brobecker [this message]
2006-12-06 16:54   ` Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061206010627.GE32651@adacore.com \
    --to=brobecker@adacore.com \
    --cc=andrew.stubbs@st.com \
    --cc=gdb-patches@sourceware.org \
    --cc=john.pye@anu.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox