Re: [committed][gdb/testsuite] Split up multi-exec test-cases

[Pedro Alves <palves@redhat.com>]

On 5/14/20 4:25 PM, Tom de Vries wrote:
> (gdb) spawn gdbserver --once localhost:2592 outputs/gdb.base/align/align^M
> Process outputs/gdb.base/align/align created; pid = 6946^M
> Listening on port 2592^M
> target remote localhost:2592^M
> Remote debugging using localhost:2592^M
> warning: Mismatch between current exec-file outputs/gdb.base/align/c/align^M
> and automatically determined exec-file outputs/gdb.base/align/align^M
> exec-file-mismatch handling is currently "ask"^M
> Load new symbol table from "outputs/gdb.base/align/align"? (y or n) Quit^M
> (gdb) ERROR: test suppressed
> ...

No objection to the splitting, but the issue above should really be
fixed.  It's a systematic issue, and requiring a file split to address it
seems like a heavy burden to me.  Maybe we should disable exec-file-mismatch
detection from within gdb_target_cmd?  At least, until we have buildid detection.
But that won't work on all hosts, either.  Like, this fixes align.exp for me:

diff --git c/gdb/testsuite/lib/gdbserver-support.exp w/gdb/testsuite/lib/gdbserver-support.exp
index a2cc80f28d7..fc79f1d60c6 100644
--- c/gdb/testsuite/lib/gdbserver-support.exp
+++ w/gdb/testsuite/lib/gdbserver-support.exp
@@ -52,7 +52,7 @@ proc gdb_target_cmd_ext { targetname serialport {additional_text ""} } {
 
     set serialport_re [string_to_regexp $serialport]
     for {set i 1} {$i <= 3} {incr i} {
-       send_gdb "target $targetname $serialport\n"
+       send_gdb "with exec-file-mismatch off -- target $targetname $serialport\n"
        gdb_expect 60 {
            -re "A program is being debugged already.*ill it.*y or n. $" {
                send_gdb "y\n"


Thanks,
Pedro Alves