From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 4AEF8395C87F for ; Thu, 14 May 2020 17:04:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4AEF8395C87F Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-77iJCtlkNquCNBxF00G50g-1; Thu, 14 May 2020 13:04:43 -0400 X-MC-Unique: 77iJCtlkNquCNBxF00G50g-1 Received: by mail-wr1-f69.google.com with SMTP id d16so1855450wrv.18 for ; Thu, 14 May 2020 10:04:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aNaxLmtDlJ8K93ftqvz4X81HrRIuk2SdmE/mpXStm1Q=; b=NFFBWJM+uCP9xj6cq01pVkM2Gx8QUd0+hZ8LTLEcrcL07+kDE1MEHEvUtQQvYzLdj4 4N42uMB33pnKdaI74np/h0xTdxnkqqPMXKNbL+2CMa7X5wOZq4smG/TOkSMqez6Ft3V9 0O6KIzhLRFu0bIb2hSVGmd349B6aimeSIQtSkx8HnqKosQ7LZraDWlvaxBIj/0/YNvHn gf6KgodXQ74Ir46wlze94plvCsmp69R8Z+Pl2pnXr2u2cG7sDAIUktUFbc4TGmeW3R4w 9KFXtoxzSyvP/oavbvmuKoPB7NWTo5lcKUBjE9lswq7r9fHTSZCD8+gF0dhb0mh50vrY uAiQ== X-Gm-Message-State: AOAM533Ldtmg9u8/GhilJzSoCMsZV7n7L3gu4/6NDHirsAuauy5jObts eXk80YvMbysM6lqX89Rep8moyoXN8dseZXb6hexfVzUgt8baEHvlzEfKhrEyp2hkuHH/tLZ7wjd CS0V7ntl6D5z0XERr8HeOzw== X-Received: by 2002:adf:ec88:: with SMTP id z8mr6116612wrn.44.1589475882082; Thu, 14 May 2020 10:04:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfP7xhM6W2kk0mdA1JHG3u40+Y7Jw6eVAsTJFq1nR/ePBvlCZy/qVCIs+jBny2vNgrz2eXkA== X-Received: by 2002:adf:ec88:: with SMTP id z8mr6116599wrn.44.1589475881898; Thu, 14 May 2020 10:04:41 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x16sm4832028wrq.23.2020.05.14.10.04.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2020 10:04:40 -0700 (PDT) Subject: Re: [committed][gdb/testsuite] Split up multi-exec test-cases To: Tom de Vries , gdb-patches@sourceware.org References: <20200514152530.GA19399@delia> From: Pedro Alves Message-ID: <456ce125-df9d-6ca7-d08d-9dae83aaed10@redhat.com> Date: Thu, 14 May 2020 18:04:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200514152530.GA19399@delia> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 17:04:48 -0000 On 5/14/20 4:25 PM, Tom de Vries wrote: > (gdb) spawn gdbserver --once localhost:2592 outputs/gdb.base/align/align^M > Process outputs/gdb.base/align/align created; pid = 6946^M > Listening on port 2592^M > target remote localhost:2592^M > Remote debugging using localhost:2592^M > warning: Mismatch between current exec-file outputs/gdb.base/align/c/align^M > and automatically determined exec-file outputs/gdb.base/align/align^M > exec-file-mismatch handling is currently "ask"^M > Load new symbol table from "outputs/gdb.base/align/align"? (y or n) Quit^M > (gdb) ERROR: test suppressed > ... No objection to the splitting, but the issue above should really be fixed. It's a systematic issue, and requiring a file split to address it seems like a heavy burden to me. Maybe we should disable exec-file-mismatch detection from within gdb_target_cmd? At least, until we have buildid detection. But that won't work on all hosts, either. Like, this fixes align.exp for me: diff --git c/gdb/testsuite/lib/gdbserver-support.exp w/gdb/testsuite/lib/gdbserver-support.exp index a2cc80f28d7..fc79f1d60c6 100644 --- c/gdb/testsuite/lib/gdbserver-support.exp +++ w/gdb/testsuite/lib/gdbserver-support.exp @@ -52,7 +52,7 @@ proc gdb_target_cmd_ext { targetname serialport {additional_text ""} } { set serialport_re [string_to_regexp $serialport] for {set i 1} {$i <= 3} {incr i} { - send_gdb "target $targetname $serialport\n" + send_gdb "with exec-file-mismatch off -- target $targetname $serialport\n" gdb_expect 60 { -re "A program is being debugged already.*ill it.*y or n. $" { send_gdb "y\n" Thanks, Pedro Alves