prologue-value.c memory leak fix.

prologue-value.c memory leak fix.

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

There is a leak in prologue-value.c, in clear_values:

The do while loop always runs exactly once.
The attached patch fixes it.

/* Delete all entries from AREA.  */
static void
clear_entries (struct pv_area *area)
{
  struct area_entry *e = area->entry;

  if (e)
    {
      /* This needs to be a do-while loop, in order to actually
         process the node being checked for in the terminating
         condition.  */
      do
        {
          struct area_entry *next = e->next;
          xfree (e);
        }
      while (e != area->entry);

      area->entry = 0;
    }
}

Please review and commit.

Cheers,
Pedro Alves

---

2006-11-18 Pedro Alves <pedro_alves@portugalmail.pt>

prologue-value.c (clear_entries): Fix memory leak.



[-- Attachment #2: prologue-value.c.diff --]
[-- Type: text/plain, Size: 499 bytes --]

Index: prologue-value.c
===================================================================
RCS file: /cvs/src/src/gdb/prologue-value.c,v
retrieving revision 1.2
diff -u -p -r1.2 prologue-value.c
--- prologue-value.c	28 Mar 2006 19:19:16 -0000	1.2
+++ prologue-value.c	18 Nov 2006 23:00:35 -0000
@@ -351,6 +351,7 @@ clear_entries (struct pv_area *area)
         {
           struct area_entry *next = e->next;
           xfree (e);
+          e = next;
         }
       while (e != area->entry);
 

Re: prologue-value.c memory leak fix.

[Daniel Jacobowitz]

On Sat, Nov 18, 2006 at 11:04:58PM +0000, Pedro Alves wrote:
> 2006-11-18 Pedro Alves <pedro_alves@portugalmail.pt>
> 
> prologue-value.c (clear_entries): Fix memory leak.
> 

Approved and applied, thanks.  I fixed up the changelog entry like so:

2006-11-18  Pedro Alves  <pedro_alves@portugalmail.pt>

	* prologue-value.c (clear_entries): Fix memory leak.

-- 
Daniel Jacobowitz
CodeSourcery