Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/5] Copy string_view files from libstdc++
Date: Mon, 09 Apr 2018 17:39:00 -0000	[thread overview]
Message-ID: <4547b461-76b4-be0f-bf39-ff8cb5c3f631@redhat.com> (raw)
In-Reply-To: <f9402203d6de3ed1ce034a45593649ad@polymtl.ca>

On 04/09/2018 06:23 PM, Simon Marchi wrote:
> On 2018-04-09 09:44, Pedro Alves wrote:
>> On 04/07/2018 02:26 PM, Simon Marchi wrote:
>>
>>> This patch copies the following files from libstdc++ (commit
>>> 02a4441f002c):
>>>
>>>   ${gcc}/include/std/string_view -> ${binutils-gdb}/gdb/common/gdb_string_view.h
>>>   ${gcc}/include/bits/string_view.tcc -> ${binutils-gdb}/gdb/common/gdb_string_view.tcc
>>
>> Nit: the source filenames here should be updated.  Maybe commit as
>> well, if applicable.
> 
> Oops, I'm missing "libstdc++-v3" in the source names.  Is there anything else wrong with the paths?  What about the commit?

That too, but I was actually thinking that the files in this revision were
copied from:

 include/experimental/string_view
 include/experimental/bits/string_view.tcc

instead?

The commit looks fine.

Thanks,
Pedro Alves


  reply	other threads:[~2018-04-09 17:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-07 13:26 [PATCH v3 1/5] Update ax_cv_cxx_compile_cxx.m4 Simon Marchi
2018-04-07 13:26 ` [PATCH v3 2/5] Copy string_view files from libstdc++ Simon Marchi
2018-04-09 13:44   ` Pedro Alves
2018-04-09 17:23     ` Simon Marchi
2018-04-09 17:39       ` Pedro Alves [this message]
2018-04-09 18:20         ` Simon Marchi
2018-04-07 13:26 ` [PATCH v3 5/5] Adapt and integrate string_view tests Simon Marchi
2018-04-09 13:45   ` Pedro Alves
2018-04-07 13:26 ` [PATCH v3 3/5] Add gdb::string_view Simon Marchi
2018-04-09 13:44   ` Pedro Alves
2018-04-09 17:28     ` Simon Marchi
2018-04-09 17:30       ` Simon Marchi
2018-04-09 18:28     ` Simon Marchi
2018-04-07 13:37 ` [PATCH v3 4/5] Copy string_view tests from libstdc++ Simon Marchi
2018-04-09 13:47   ` Pedro Alves
2018-04-09 13:46 ` [PATCH v3 1/5] Update ax_cv_cxx_compile_cxx.m4 Pedro Alves
2018-04-09 18:27 ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4547b461-76b4-be0f-bf39-ff8cb5c3f631@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox