From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109229 invoked by alias); 9 Apr 2018 17:39:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109218 invoked by uid 89); 9 Apr 2018 17:39:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 17:39:43 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C51087D843; Mon, 9 Apr 2018 17:39:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 482DF1102E2C; Mon, 9 Apr 2018 17:39:41 +0000 (UTC) Subject: Re: [PATCH v3 2/5] Copy string_view files from libstdc++ To: Simon Marchi References: <20180407132629.3787-1-simon.marchi@polymtl.ca> <20180407132629.3787-2-simon.marchi@polymtl.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4547b461-76b4-be0f-bf39-ff8cb5c3f631@redhat.com> Date: Mon, 09 Apr 2018 17:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-04/txt/msg00156.txt.bz2 On 04/09/2018 06:23 PM, Simon Marchi wrote: > On 2018-04-09 09:44, Pedro Alves wrote: >> On 04/07/2018 02:26 PM, Simon Marchi wrote: >> >>> This patch copies the following files from libstdc++ (commit >>> 02a4441f002c): >>> >>>   ${gcc}/include/std/string_view -> ${binutils-gdb}/gdb/common/gdb_string_view.h >>>   ${gcc}/include/bits/string_view.tcc -> ${binutils-gdb}/gdb/common/gdb_string_view.tcc >> >> Nit: the source filenames here should be updated.  Maybe commit as >> well, if applicable. > > Oops, I'm missing "libstdc++-v3" in the source names.  Is there anything else wrong with the paths?  What about the commit? That too, but I was actually thinking that the files in this revision were copied from: include/experimental/string_view include/experimental/bits/string_view.tcc instead? The commit looks fine. Thanks, Pedro Alves