From: Bob Wilson <bwilson@tensilica.com>
To: gdb-patches@sources.redhat.com
Cc: Daniel Jacobowitz <drow@false.org>
Subject: Re: [PATCH] print newline after copyright message
Date: Mon, 24 Jul 2006 20:43:00 -0000 [thread overview]
Message-ID: <44C530F7.8090306@tensilica.com> (raw)
In-Reply-To: <20060724201846.GC15759@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Wed, Jul 19, 2006 at 01:33:34PM -0700, Bob Wilson wrote:
>> 2006-07-19 Bob Wilson <bob.wilson@acm.org>
>>
>> * main.c (captured_main): Print a newline after calling
>> print_gdb_version instead of waiting until after the symbol
>> file
>> has been read. Adjust {error,quit,warning}_pre_print values.
>>
>
> Thanks, I agree with your logic. This patch is OK. Please don't use
> {A,B} notation in changelogs, though - spell it out.
I don't work on GDB much, so I'm not on the write-after-approval list in the
MAINTAINERS file. If my write access for binutils applies to the gdb directory
(I don't know how that works), I would be happy to apply the patch. Is that OK?
Otherwise, would you apply it for me? Here is the revised changelog:
2006-07-24 Bob Wilson <bob.wilson@acm.org>
* main.c (captured_main): Print a newline after calling
print_gdb_version instead of waiting until after the symbol file
has been read. Adjust error_pre_print, quit_pre_print, and
warning_pre_print values.
next prev parent reply other threads:[~2006-07-24 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 20:35 Bob Wilson
2006-07-24 20:18 ` Daniel Jacobowitz
2006-07-24 20:43 ` Bob Wilson [this message]
2006-07-27 21:33 ` Daniel Jacobowitz
2006-07-27 23:06 ` Bob Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C530F7.8090306@tensilica.com \
--to=bwilson@tensilica.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox