From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4240 invoked by alias); 24 Jul 2006 20:43:46 -0000 Received: (qmail 4221 invoked by uid 22791); 24 Jul 2006 20:43:43 -0000 X-Spam-Check-By: sourceware.org Received: from hq.tensilica.com (HELO mailapp.tensilica.com) (65.205.227.29) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 24 Jul 2006 20:43:41 +0000 Received: from localhost ([127.0.0.1] ident=amavis) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1G57H6-0008QK-Dy; Mon, 24 Jul 2006 13:43:36 -0700 Received: from mailapp.tensilica.com ([127.0.0.1]) by localhost (mailapp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 30541-04; Mon, 24 Jul 2006 13:43:36 -0700 (PDT) Received: from heron.hq.tensilica.com ([192.168.11.123]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1G57H6-0008QF-4L; Mon, 24 Jul 2006 13:43:36 -0700 Received: from [192.168.11.123] (heron.hq.tensilica.com [192.168.11.123]) by heron.hq.tensilica.com (Postfix) with ESMTP id 125CCAC205; Mon, 24 Jul 2006 13:43:36 -0700 (PDT) Message-ID: <44C530F7.8090306@tensilica.com> Date: Mon, 24 Jul 2006 20:43:00 -0000 From: Bob Wilson User-Agent: Thunderbird 1.5.0.4 (X11/20060615) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com CC: Daniel Jacobowitz Subject: Re: [PATCH] print newline after copyright message References: <4502EB65-3352-4094-8397-AD0E93913023@tensilica.com> <20060724201846.GC15759@nevyn.them.org> In-Reply-To: <20060724201846.GC15759@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00359.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jul 19, 2006 at 01:33:34PM -0700, Bob Wilson wrote: >> 2006-07-19 Bob Wilson >> >> * main.c (captured_main): Print a newline after calling >> print_gdb_version instead of waiting until after the symbol >> file >> has been read. Adjust {error,quit,warning}_pre_print values. >> > > Thanks, I agree with your logic. This patch is OK. Please don't use > {A,B} notation in changelogs, though - spell it out. I don't work on GDB much, so I'm not on the write-after-approval list in the MAINTAINERS file. If my write access for binutils applies to the gdb directory (I don't know how that works), I would be happy to apply the patch. Is that OK? Otherwise, would you apply it for me? Here is the revised changelog: 2006-07-24 Bob Wilson * main.c (captured_main): Print a newline after calling print_gdb_version instead of waiting until after the symbol file has been read. Adjust error_pre_print, quit_pre_print, and warning_pre_print values.