add bare_board variable

add bare_board variable

[Nathan Sidwell]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

This patch adds a bare_board target_info variable to skip a couple of tests that
presume some kind of OS is running.

The start.exp test doesn't work when a gdb stub is being used.

ok?

nathan
-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk


[-- Attachment #2: test-bare.patch --]
[-- Type: text/x-patch, Size: 2281 bytes --]

2006-06-09  Nathan Sidwell  <nathan@codesourcery.com>

	gdb/testsuite/
	* gdb.base/auxv.exp: Skip if bare_board
	* gdb.base/gdb1555.exp: Likewise.
	* gdb.base/start.exp: Skip if use_gdb_stub.

Index: gdb/testsuite/gdb.base/auxv.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/auxv.exp,v
retrieving revision 1.4
diff -c -3 -p -r1.4 auxv.exp
*** gdb/testsuite/gdb.base/auxv.exp	2 May 2005 20:57:30 -0000	1.4
--- gdb/testsuite/gdb.base/auxv.exp	9 Jun 2006 21:03:25 -0000
***************
*** 23,28 ****
--- 23,33 ----
  # This file is based on corefile.exp which was written by Fred
  # Fish. (fnf@cygnus.com)
  
+ if [target_info exists bare_board] then {
+     verbose "Skipping auxv.exp because of bare_board."
+     return
+ }
+ 
  if $tracelevel then {
  	strace $tracelevel
  }
Index: gdb/testsuite/gdb.base/gdb1555.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb1555.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 gdb1555.exp
*** gdb/testsuite/gdb.base/gdb1555.exp	18 Feb 2004 03:35:08 -0000	1.1
--- gdb/testsuite/gdb.base/gdb1555.exp	9 Jun 2006 21:03:26 -0000
***************
*** 21,26 ****
--- 21,31 ----
  # a shared library (PR gdb/1555, was PR shlib/1280, shlib/1237).
  # Tested on ppc-yellowdog-linux (Yellow Dog Linux 3.0 3.2.2-2a)
  
+ if [target_info exists bare_board] then {
+     verbose "Skipping gdb1555.exp because of bare_board."
+     return
+ }
+ 
  if $tracelevel then {
      strace $tracelevel
  }
Index: gdb/testsuite/gdb.base/start.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/start.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 start.exp
*** gdb/testsuite/gdb.base/start.exp	9 Feb 2005 19:58:23 -0000	1.1
--- gdb/testsuite/gdb.base/start.exp	9 Jun 2006 21:03:26 -0000
***************
*** 14,19 ****
--- 14,24 ----
  # along with this program; if not, write to the Free Software
  # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
  
+ if [target_info use_gdb_stub] {
+     verbose "Skipping start.exp because of use_gdb_stub."
+     return
+ }
+ 
  if $tracelevel then {
      strace $tracelevel
  }

Re: add bare_board variable

[Nathan Sidwell]

Nathan Sidwell wrote:
> This patch adds a bare_board target_info variable to skip a couple of tests that
> presume some kind of OS is running.
> 
> The start.exp test doesn't work when a gdb stub is being used.

ping?

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Re: add bare_board variable

[Nathan Sidwell]

ping?

Nathan Sidwell wrote:
> This patch adds a bare_board target_info variable to skip a couple of tests that
> presume some kind of OS is running.
> 
> The start.exp test doesn't work when a gdb stub is being used.
> 
> ok?
> 
> nathan
> 
> 
> ------------------------------------------------------------------------
> 
> 2006-06-09  Nathan Sidwell  <nathan@codesourcery.com>
> 
> 	gdb/testsuite/
> 	* gdb.base/auxv.exp: Skip if bare_board
> 	* gdb.base/gdb1555.exp: Likewise.
> 	* gdb.base/start.exp: Skip if use_gdb_stub.
> 
> Index: gdb/testsuite/gdb.base/auxv.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/auxv.exp,v
> retrieving revision 1.4
> diff -c -3 -p -r1.4 auxv.exp
> *** gdb/testsuite/gdb.base/auxv.exp	2 May 2005 20:57:30 -0000	1.4
> --- gdb/testsuite/gdb.base/auxv.exp	9 Jun 2006 21:03:25 -0000
> ***************
> *** 23,28 ****
> --- 23,33 ----
>   # This file is based on corefile.exp which was written by Fred
>   # Fish. (fnf@cygnus.com)
>   
> + if [target_info exists bare_board] then {
> +     verbose "Skipping auxv.exp because of bare_board."
> +     return
> + }
> + 
>   if $tracelevel then {
>   	strace $tracelevel
>   }
> Index: gdb/testsuite/gdb.base/gdb1555.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb1555.exp,v
> retrieving revision 1.1
> diff -c -3 -p -r1.1 gdb1555.exp
> *** gdb/testsuite/gdb.base/gdb1555.exp	18 Feb 2004 03:35:08 -0000	1.1
> --- gdb/testsuite/gdb.base/gdb1555.exp	9 Jun 2006 21:03:26 -0000
> ***************
> *** 21,26 ****
> --- 21,31 ----
>   # a shared library (PR gdb/1555, was PR shlib/1280, shlib/1237).
>   # Tested on ppc-yellowdog-linux (Yellow Dog Linux 3.0 3.2.2-2a)
>   
> + if [target_info exists bare_board] then {
> +     verbose "Skipping gdb1555.exp because of bare_board."
> +     return
> + }
> + 
>   if $tracelevel then {
>       strace $tracelevel
>   }
> Index: gdb/testsuite/gdb.base/start.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/start.exp,v
> retrieving revision 1.1
> diff -c -3 -p -r1.1 start.exp
> *** gdb/testsuite/gdb.base/start.exp	9 Feb 2005 19:58:23 -0000	1.1
> --- gdb/testsuite/gdb.base/start.exp	9 Jun 2006 21:03:26 -0000
> ***************
> *** 14,19 ****
> --- 14,24 ----
>   # along with this program; if not, write to the Free Software
>   # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
>   
> + if [target_info use_gdb_stub] {
> +     verbose "Skipping start.exp because of use_gdb_stub."
> +     return
> + }
> + 
>   if $tracelevel then {
>       strace $tracelevel
>   }


-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Re: add bare_board variable

[Daniel Jacobowitz]

On Fri, Jun 09, 2006 at 10:09:48PM +0100, Nathan Sidwell wrote:
> This patch adds a bare_board target_info variable to skip a couple of tests that
> presume some kind of OS is running.

I don't really like this.  They don't presume "some OS"; the presume
OS's with specific capabilities.

auxv.exp will only pass on Linux and solaris2; a target test would be
OK.  Want to do that?  Just istarget; they should pass even for remote
targets.

I recently modified gdb1555.exp in such a way that I don't think your
patch is necessary any more.

> The start.exp test doesn't work when a gdb stub is being used.

Do you think that start should work for remote targets, and be
equivalent to "tbreak main; continue" instead of "tbreak main; run"?
Or maybe it should issue an error instead of trying to run?


-- 
Daniel Jacobowitz
CodeSourcery

Re: add bare_board variable

[Nathan Sidwell]

Daniel Jacobowitz wrote:
> On Fri, Jun 09, 2006 at 10:09:48PM +0100, Nathan Sidwell wrote:
>> This patch adds a bare_board target_info variable to skip a couple of tests that
>> presume some kind of OS is running.
> 
> I don't really like this.  They don't presume "some OS"; the presume
> OS's with specific capabilities.
> 
> auxv.exp will only pass on Linux and solaris2; a target test would be
> OK.  Want to do that?  Just istarget; they should pass even for remote
> targets.
Ok, I'll address that

>> The start.exp test doesn't work when a gdb stub is being used.
> 
> Do you think that start should work for remote targets, and be
> equivalent to "tbreak main; continue" instead of "tbreak main; run"?
> Or maybe it should issue an error instead of trying to run?

Although 'tbreak main; continue' would be nice, it'll only work after a load, 
otherwise the state won't be right.  Or, can gdb pull the entry point address 
out of the current file and do 'tbreak main; j *<addr>' ?

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Re: add bare_board variable

[Daniel Jacobowitz]

On Wed, Jul 19, 2006 at 05:18:56PM +0100, Nathan Sidwell wrote:
> >Do you think that start should work for remote targets, and be
> >equivalent to "tbreak main; continue" instead of "tbreak main; run"?
> >Or maybe it should issue an error instead of trying to run?
> 
> Although 'tbreak main; continue' would be nice, it'll only work after a 
> load, otherwise the state won't be right.  Or, can gdb pull the entry point 
> address out of the current file and do 'tbreak main; j *<addr>' ?

It could... but who knows where you'd end up?  We've seen that
sometimes more of a reset is needed.  I guess we should make it issue a
sensible error, and allow the test to pass when it sees that error.

-- 
Daniel Jacobowitz
CodeSourcery