Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>,
	        GDB Patches <gdb-patches@sources.redhat.com>,
	        Fred Fish <fnf@specifix.com>
Subject: [RFA] mips, floating point arg passing
Date: Wed, 31 May 2006 23:35:00 -0000	[thread overview]
Message-ID: <447E279C.7020804@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 89 bytes --]

GDB is causing SIGFPE on target boards that have a FPU,
when compiled for a 32 bit ABI.


[-- Attachment #2: d3 --]
[-- Type: text/plain, Size: 1885 bytes --]

2006-05-31  Michael Snyder  <msnyder@redhat.com>

	* mips-tdep.c (mips_eabi_push_dummy_call): For 32 bit ABI, to
	decide how many registers it takes to pass a floating point
	argument, what matters is the size of a floating point register
	(not the size of a general purpose register).
	(mips_o32_push_dummy_call): Ditto.

Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.393
diff -p -r1.393 mips-tdep.c
*** mips-tdep.c	31 May 2006 23:15:50 -0000	1.393
--- mips-tdep.c	31 May 2006 23:28:59 -0000
*************** mips_eabi_push_dummy_call (struct gdbarc
*** 2494,2500 ****
        if (fp_register_arg_p (typecode, arg_type)
  	  && float_argreg <= MIPS_LAST_FP_ARG_REGNUM)
  	{
! 	  if (mips_abi_regsize (gdbarch) < 8 && len == 8)
  	    {
  	      int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0;
  	      unsigned long regval;
--- 2494,2500 ----
        if (fp_register_arg_p (typecode, arg_type)
  	  && float_argreg <= MIPS_LAST_FP_ARG_REGNUM)
  	{
! 	  if (register_size (gdbarch, float_argreg) < 8 && len == 8)
  	    {
  	      int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0;
  	      unsigned long regval;
*************** mips_o32_push_dummy_call (struct gdbarch
*** 3118,3124 ****
        if (fp_register_arg_p (typecode, arg_type)
  	  && float_argreg <= MIPS_LAST_FP_ARG_REGNUM)
  	{
! 	  if (mips_abi_regsize (gdbarch) < 8 && len == 8)
  	    {
  	      int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0;
  	      unsigned long regval;
--- 3118,3124 ----
        if (fp_register_arg_p (typecode, arg_type)
  	  && float_argreg <= MIPS_LAST_FP_ARG_REGNUM)
  	{
! 	  if (register_size (gdbarch, float_argreg) < 8 && len == 8)
  	    {
  	      int low_offset = TARGET_BYTE_ORDER == BFD_ENDIAN_BIG ? 4 : 0;
  	      unsigned long regval;

             reply	other threads:[~2006-05-31 23:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-31 23:35 Michael Snyder [this message]
2006-06-08 19:16 ` Michael Snyder
2006-06-09 18:05 ` Joel Brobecker
2006-06-09 18:20   ` Daniel Jacobowitz
2006-06-19 18:50   ` Michael Snyder
2006-06-19 18:57     ` Mark Kettenis
2006-06-17 23:36 ` Mark Kettenis
2006-06-19 22:30   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447E279C.7020804@redhat.com \
    --to=msnyder@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=fnf@specifix.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox