Re: [RFA] mips, floating point arg passing

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Mon, 19 Jun 2006 11:50:11 -0700
> From: Michael Snyder <msnyder@redhat.com>
> 
> Joel Brobecker wrote:
> > Hello Michael,
> > 
> > 
> >>GDB is causing SIGFPE on target boards that have a FPU,
> >>when compiled for a 32 bit ABI.
> > 
> > 
> > I've only worked with the n32 ABI so far, so I'm not familiar with
> > the EABI nor o32 ABI. But I presume you know what you're talking
> > about :-).
> > 
> > 
> >>2006-05-31  Michael Snyder  <msnyder@redhat.com>
> >>
> >>	* mips-tdep.c (mips_eabi_push_dummy_call): For 32 bit ABI, to
> >>	decide how many registers it takes to pass a floating point
> >>	argument, what matters is the size of a floating point register
> >>	(not the size of a general purpose register).
> >>	(mips_o32_push_dummy_call): Ditto.
> > 
> > 
> > I'm not sure I really have the knowledge to approve but Daniel asked
> > for help in that department, so I'll give it a try.
> > 
> > This patch seems pretty logical to me, so go ahead and commit. Is it
> > possible to run the testsuite on either o32, or on a target board?
> 
> I did -- but it was quite some time ago now, and I couldn't
> really put my hands on them.  I'm pretty sure they got better.
> Certainly they didn't get worse.
> 
> Committing.
> 

Whoa wait, you didn't answer my questions about the patch...