Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 4/4] gdb/dwarf: use dynamic partitioning for DWARF CU indexing
Date: Fri, 19 Sep 2025 16:15:47 -0400	[thread overview]
Message-ID: <4451ecf5-2335-45f0-aeed-5fb5e124bae2@polymtl.ca> (raw)
In-Reply-To: <87h5wzfsg4.fsf@tromey.com>

On 9/18/25 3:53 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> Yeah, that's unfortunate.  It's because
> Simon> std::atomic<std::vector<...>::iterator> won't work with
> Simon> -D_GLIBCXX_DEBUG.  If I try to use iterators all the way, I get:
> 
> Simon> /opt/gcc/15.2.0/include/c++/15.2.0/atomic:214:21: error: static assertion failed: std::atomic requires a trivially copyable type
> Simon>   214 |       static_assert(__is_trivially_copyable(_Tp),
> Simon>       |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Simon> Without _GLIBCXX_DEBUG, vector iterators boil down to just a pointer.
> Simon> But with _GLIBCXX_DEBUG, there is additional state.
> 
> Simon> I still want to be able to use _GLIBCXX_DEBUG, it's pretty useful.
> 
> Maybe a comment to this effect would be nice to have.
> 
> thanks,
> Tom

Ok, added.

Simon

  reply	other threads:[~2025-09-19 20:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 20:01 [PATCH v2 1/4] gdbsupport: use dynamic partitioning in gdb::parallel_for_each simon.marchi
2025-07-03 20:01 ` [PATCH v2 2/4] gdbsupport: factor out work queue from parallel-for.h simon.marchi
2025-09-18 19:07   ` Tom Tromey
2025-09-19 18:06     ` Simon Marchi
2025-07-03 20:01 ` [PATCH v2 3/4] gdbsupport: add async parallel_for_each version simon.marchi
2025-09-18 19:16   ` Tom Tromey
2025-09-19 20:12     ` Simon Marchi
2025-07-03 20:01 ` [PATCH v2 4/4] gdb/dwarf: use dynamic partitioning for DWARF CU indexing simon.marchi
2025-09-18 19:26   ` Tom Tromey
2025-09-18 19:46     ` Simon Marchi
2025-09-18 19:53       ` Tom Tromey
2025-09-19 20:15         ` Simon Marchi [this message]
2025-08-05 17:01 ` [PATCH v2 1/4] gdbsupport: use dynamic partitioning in gdb::parallel_for_each Simon Marchi
2025-08-28 17:00   ` Simon Marchi
2025-09-08 17:23     ` Simon Marchi
2025-09-18 18:59 ` Tom Tromey
2025-09-19 17:47   ` Simon Marchi
2025-09-19 18:04     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4451ecf5-2335-45f0-aeed-5fb5e124bae2@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox