Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>, simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/4] gdbsupport: factor out work queue from parallel-for.h
Date: Fri, 19 Sep 2025 14:06:46 -0400	[thread overview]
Message-ID: <02e50a99-c110-4463-8a6f-5be7221e4c70@efficios.com> (raw)
In-Reply-To: <878qibh94v.fsf@tromey.com>

On 9/18/25 3:07 PM, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> +  /* Pop a batch of work items.
> Simon> +
> Simon> +     The return value is a pair containing iterators to the first and last
> Simon> +     (exclusive) work items.  */
> Simon> +  std::pair<RandomIt, RandomIt> pop_batch () noexcept
> 
> How about using an iterator_range<> here instead?
> It's basically a pair but a bit more specialized.

I think it's a good idea.  I'm also experimenting in using
iterator_range in the parallel_for_each interface.  That is, make the
worker function receive an iterator_range, rather than separate
begin/end parameters.  That makes it even easier to use a ranged for
loop in the worker, which is nice.

Simon

  reply	other threads:[~2025-09-19 18:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 20:01 [PATCH v2 1/4] gdbsupport: use dynamic partitioning in gdb::parallel_for_each simon.marchi
2025-07-03 20:01 ` [PATCH v2 2/4] gdbsupport: factor out work queue from parallel-for.h simon.marchi
2025-09-18 19:07   ` Tom Tromey
2025-09-19 18:06     ` Simon Marchi [this message]
2025-07-03 20:01 ` [PATCH v2 3/4] gdbsupport: add async parallel_for_each version simon.marchi
2025-09-18 19:16   ` Tom Tromey
2025-09-19 20:12     ` Simon Marchi
2025-07-03 20:01 ` [PATCH v2 4/4] gdb/dwarf: use dynamic partitioning for DWARF CU indexing simon.marchi
2025-09-18 19:26   ` Tom Tromey
2025-09-18 19:46     ` Simon Marchi
2025-09-18 19:53       ` Tom Tromey
2025-09-19 20:15         ` Simon Marchi
2025-08-05 17:01 ` [PATCH v2 1/4] gdbsupport: use dynamic partitioning in gdb::parallel_for_each Simon Marchi
2025-08-28 17:00   ` Simon Marchi
2025-09-08 17:23     ` Simon Marchi
2025-09-18 18:59 ` Tom Tromey
2025-09-19 17:47   ` Simon Marchi
2025-09-19 18:04     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02e50a99-c110-4463-8a6f-5be7221e4c70@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox