From: Andrew STUBBS <andrew.stubbs@st.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,
gdb-patches@sourceware.org, insight@sourceware.org
Subject: Re: [PATCH] Don't call Insight hooks when not appropriate
Date: Wed, 29 Mar 2006 18:27:00 -0000 [thread overview]
Message-ID: <442AB783.4060602@st.com> (raw)
In-Reply-To: <20060329162852.GA631@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Wed, Mar 29, 2006 at 04:55:35PM +0100, Andrew STUBBS wrote:
>> Daniel Jacobowitz wrote:
>>> It looked much like what you've posted below, except more thorough
>>> (e.g. you missed defaulted_query). I can see the whole patch in the
>>> list archives, so I wonder if your mail client ate it.
>> I see what's happened; there's a form-feed, or something, in it and that
>> has caused the confusion.
>>
>> Sorry, I'll try your patch properly.
>
> D'oh! Thanks. A lot of GDB code uses those for page breaks.
Yes, it is irritating, but I'm sure somebody likes them.
I have now tested your full patch. I could not get it to compile without
adding 'caution' to top.h and including top.h in utils.c.
With that one change it does what I want. Thanks.
One small query: defaulted_query() used to return def_value, but now
always returns 1. This does not seem to be the same thing. The new text
is identical to that in query(), which smells like a paste-o to me.
Andrew
next prev parent reply other threads:[~2006-03-29 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 18:15 Andrew STUBBS
2006-03-09 19:49 ` Mark Kettenis
2006-03-09 20:03 ` Daniel Jacobowitz
2006-03-09 20:04 ` Daniel Jacobowitz
2006-03-10 0:19 ` Michael Snyder
2006-03-10 19:09 ` Andrew STUBBS
2006-03-10 19:16 ` Andrew STUBBS
2006-03-25 7:00 ` Daniel Jacobowitz
2006-03-27 19:57 ` Andrew STUBBS
2006-03-28 22:18 ` Daniel Jacobowitz
2006-03-29 16:29 ` Andrew STUBBS
2006-03-29 16:38 ` Daniel Jacobowitz
2006-03-29 16:45 ` Andrew STUBBS
2006-03-29 18:01 ` Daniel Jacobowitz
2006-03-29 18:27 ` Andrew STUBBS [this message]
2006-03-29 22:53 ` Dave Korn
2006-03-29 23:00 ` Eli Zaretskii
2006-03-29 23:22 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442AB783.4060602@st.com \
--to=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
--cc=insight@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox