From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31251 invoked by alias); 29 Mar 2006 16:38:58 -0000 Received: (qmail 31237 invoked by uid 22791); 29 Mar 2006 16:38:58 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-03.spheriq.net (HELO lon-del-03.spheriq.net) (195.46.50.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Mar 2006 16:38:56 +0000 Received: from lon-out-02.spheriq.net ([195.46.50.130]) by lon-del-03.spheriq.net with ESMTP id k2TGcrtJ010700 for ; Wed, 29 Mar 2006 16:38:53 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-02.spheriq.net with ESMTP id k2TGcrJK028822 for ; Wed, 29 Mar 2006 16:38:53 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id k2TGcqvl017392 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Wed, 29 Mar 2006 16:38:52 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 26FA4DA41; Wed, 29 Mar 2006 16:38:52 +0000 (GMT) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7A66F474DA; Wed, 29 Mar 2006 16:42:51 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHK16368 (AUTH stubbsa); Wed, 29 Mar 2006 17:38:48 +0100 (BST) Message-ID: <442AB783.4060602@st.com> Date: Wed, 29 Mar 2006 18:27:00 -0000 From: Andrew STUBBS User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Mark Kettenis , gdb-patches@sourceware.org, insight@sourceware.org Subject: Re: [PATCH] Don't call Insight hooks when not appropriate References: <44104BB2.6000108@st.com> <200603091910.k29JAucq014442@elgar.sibelius.xs4all.nl> <20060309191304.GA31165@nevyn.them.org> <44115FE2.4070206@st.com> <20060325000428.GH26748@nevyn.them.org> <4427CCAC.3030800@st.com> <20060328215858.GC10392@nevyn.them.org> <442AAA5F.1010004@st.com> <20060329154931.GA31875@nevyn.them.org> <442AADF7.2020304@st.com> <20060329162852.GA631@nevyn.them.org> In-Reply-To: <20060329162852.GA631@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.01 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00345.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Mar 29, 2006 at 04:55:35PM +0100, Andrew STUBBS wrote: >> Daniel Jacobowitz wrote: >>> It looked much like what you've posted below, except more thorough >>> (e.g. you missed defaulted_query). I can see the whole patch in the >>> list archives, so I wonder if your mail client ate it. >> I see what's happened; there's a form-feed, or something, in it and that >> has caused the confusion. >> >> Sorry, I'll try your patch properly. > > D'oh! Thanks. A lot of GDB code uses those for page breaks. Yes, it is irritating, but I'm sure somebody likes them. I have now tested your full patch. I could not get it to compile without adding 'caution' to top.h and including top.h in utils.c. With that one change it does what I want. Thanks. One small query: defaulted_query() used to return def_value, but now always returns 1. This does not seem to be the same thing. The new text is identical to that in query(), which smells like a paste-o to me. Andrew