Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jason Kraftcheck <kraftche@cae.wisc.edu>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: list/edit command on frame with available symtab
Date: Thu, 23 Feb 2006 22:13:00 -0000	[thread overview]
Message-ID: <43FE2556.8040207@cae.wisc.edu> (raw)
In-Reply-To: <20060223210007.GB2353@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Thu, Feb 23, 2006 at 12:40:11PM -0600, Jason Kraftcheck wrote:
> 
>>If there is no symtab for the current frame, traverse up the stack
>>looking for a frame with a symtab.  This may at first seem like a
>>gratuitous feature (and perhaps it is), but I find it is convenient when
>>working with an application that uses third-party libraries.  Typically
>>whatever code I'm working on has debug symbols while whatever
>>third-party code I'm calling does not.  And I'm much more interested in
>>seeing where the process was in my code at the time a fault occurred.  I
>>don't think this change will be a problem for anyone, as the previous
>>behavior was to print an error if there was no symtab.
>>
>>
>>2006-02-23  Jason Kraftcheck  <kraftche@cae.wisc.edu>
>>
>>	* stack.c (set_current_sal_from_frame): If list or edit command
>>        is invoked for a frame without a symtab, move up the stack to
>>        the neareast frame with a symtab.
> 
> 
> I'm not sure this is a good idea, but in any case, is that really
> what's going on? I already get successful "list", and edit opens a file
> named "unknown", if the parent frame has line info.
> 

With this patch, I get what I expect.  Without this patch, stopping due
to a sigabrt, edit and list both show whatever was the previous valid
sal, which is probably a bug.  After moving up or down a frame, they
both report an error (in the edit case, editing a file called "unknown").


  reply	other threads:[~2006-02-23 21:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23 18:45 Jason Kraftcheck
2006-02-23 21:02 ` Daniel Jacobowitz
2006-02-23 22:13   ` Jason Kraftcheck [this message]
2006-03-01 22:35     ` Michael Snyder
2006-03-30 16:26       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FE2556.8040207@cae.wisc.edu \
    --to=kraftche@cae.wisc.edu \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox