From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30136 invoked by alias); 23 Feb 2006 21:13:33 -0000 Received: (qmail 30128 invoked by uid 22791); 23 Feb 2006 21:13:32 -0000 X-Spam-Check-By: sourceware.org Received: from mail.cae.wisc.edu (HELO mail.cae.wisc.edu) (144.92.13.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 23 Feb 2006 21:13:31 +0000 Received: from [128.104.187.108] (rincewind.neep.wisc.edu [128.104.187.108]) by mail.cae.wisc.edu (8.13.4/8.13.4) with ESMTP id k1NLCsaZ022999; Thu, 23 Feb 2006 15:12:54 -0600 (CST) Message-ID: <43FE2556.8040207@cae.wisc.edu> Date: Thu, 23 Feb 2006 22:13:00 -0000 From: Jason Kraftcheck User-Agent: Debian Thunderbird 1.0.7 (X11/20051017) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: list/edit command on frame with available symtab References: <43FE018B.2050502@cae.wisc.edu> <20060223210007.GB2353@nevyn.them.org> In-Reply-To: <20060223210007.GB2353@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-CAE-MailScanner-Information: Please contact security@engr.wisc.edu if this message contains a virus or has been corrupted in delivery. X-CAE-MailScanner: Found to be clean (benji) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00443.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Feb 23, 2006 at 12:40:11PM -0600, Jason Kraftcheck wrote: > >>If there is no symtab for the current frame, traverse up the stack >>looking for a frame with a symtab. This may at first seem like a >>gratuitous feature (and perhaps it is), but I find it is convenient when >>working with an application that uses third-party libraries. Typically >>whatever code I'm working on has debug symbols while whatever >>third-party code I'm calling does not. And I'm much more interested in >>seeing where the process was in my code at the time a fault occurred. I >>don't think this change will be a problem for anyone, as the previous >>behavior was to print an error if there was no symtab. >> >> >>2006-02-23 Jason Kraftcheck >> >> * stack.c (set_current_sal_from_frame): If list or edit command >> is invoked for a frame without a symtab, move up the stack to >> the neareast frame with a symtab. > > > I'm not sure this is a good idea, but in any case, is that really > what's going on? I already get successful "list", and edit opens a file > named "unknown", if the parent frame has line info. > With this patch, I get what I expect. Without this patch, stopping due to a sigabrt, edit and list both show whatever was the previous valid sal, which is probably a bug. After moving up or down a frame, they both report an error (in the edit case, editing a file called "unknown").