Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew STUBBS <andrew.stubbs@st.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Allow spaces in pathnames to directory command
Date: Mon, 20 Feb 2006 18:09:00 -0000	[thread overview]
Message-ID: <43FA053B.6060502@st.com> (raw)
In-Reply-To: <20060220171943.GA19356@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Tue, Dec 06, 2005 at 03:17:07PM +0000, Andrew STUBBS wrote:
>> Andrew Stubbs wrote:
>>> The directory command and the -d switch do not support pathnames that 
>>> contain spaces.
>> It looks like my patch ought to fix PR gdb/1832, PR gdb/956, and perhaps 
>> PR gdb/535.
> 
> Does Andrew's comment about filename_completer in gdb/535 still apply?

Yeah, I suppose it does. Certainly the auto-completer completes names 
with spaces in (provided that the spaces are not in the part already 
typed), but does not add any form of quoting.

It doesn't quote quotes or spaces. Nor does it complete filenames that 
have quoted elements already in them.

This doesn't change the correctness of the patches in question though. 
The bug report gdb/535 complains about the behaviour of generic_load(), 
not the auto-completer - that's a separate issue raised by Andrew Cagney.

I do agree that the completer ought to be fixed at some point.

Andrew


  reply	other threads:[~2006-02-20 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-06 21:39 Andrew STUBBS
2005-12-06 22:08 ` Andrew STUBBS
2006-02-20 17:19   ` Daniel Jacobowitz
2006-02-20 18:09     ` Andrew STUBBS [this message]
2006-02-20 19:19       ` Daniel Jacobowitz
2006-02-21 18:55         ` Daniel Jacobowitz
2006-02-21 20:15           ` Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43FA053B.6060502@st.com \
    --to=andrew.stubbs@st.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox