From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14000 invoked by alias); 20 Feb 2006 18:09:17 -0000 Received: (qmail 13991 invoked by uid 22791); 20 Feb 2006 18:09:16 -0000 X-Spam-Check-By: sourceware.org Received: from fra-del-04.spheriq.net (HELO fra-del-04.spheriq.net) (195.46.51.100) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Feb 2006 18:09:14 +0000 Received: from fra-out-02.spheriq.net (fra-out-02.spheriq.net [195.46.51.130]) by fra-del-04.spheriq.net with ESMTP id k1KI9Abu003033 for ; Mon, 20 Feb 2006 18:09:10 GMT Received: from fra-cus-02.spheriq.net (fra-cus-02.spheriq.net [195.46.51.38]) by fra-out-02.spheriq.net with ESMTP id k1KI9AHC010042 for ; Mon, 20 Feb 2006 18:09:10 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-02.spheriq.net with ESMTP id k1KI96Jm014664 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK) for ; Mon, 20 Feb 2006 18:09:09 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C0915DA41 for ; Mon, 20 Feb 2006 18:09:05 +0000 (GMT) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BF0E4476B0 for ; Mon, 20 Feb 2006 18:12:49 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHF88856 (AUTH stubbsa); Mon, 20 Feb 2006 18:09:04 GMT Message-ID: <43FA053B.6060502@st.com> Date: Mon, 20 Feb 2006 18:09:00 -0000 From: Andrew STUBBS User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: GDB Patches Subject: Re: [PATCH] Allow spaces in pathnames to directory command References: <4395AA58.90505@st.com> <4395AB73.2030704@st.com> <20060220171943.GA19356@nevyn.them.org> In-Reply-To: <20060220171943.GA19356@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.01 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00375.txt.bz2 Daniel Jacobowitz wrote: > On Tue, Dec 06, 2005 at 03:17:07PM +0000, Andrew STUBBS wrote: >> Andrew Stubbs wrote: >>> The directory command and the -d switch do not support pathnames that >>> contain spaces. >> It looks like my patch ought to fix PR gdb/1832, PR gdb/956, and perhaps >> PR gdb/535. > > Does Andrew's comment about filename_completer in gdb/535 still apply? Yeah, I suppose it does. Certainly the auto-completer completes names with spaces in (provided that the spaces are not in the part already typed), but does not add any form of quoting. It doesn't quote quotes or spaces. Nor does it complete filenames that have quoted elements already in them. This doesn't change the correctness of the patches in question though. The bug report gdb/535 complains about the behaviour of generic_load(), not the auto-completer - that's a separate issue raised by Andrew Cagney. I do agree that the completer ought to be fixed at some point. Andrew