Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Jim Blandy <jimb@red-bean.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Detect closed file descriptors on Windows
Date: Thu, 12 Jan 2006 15:57:00 -0000	[thread overview]
Message-ID: <43C67C4C.7090605@codesourcery.com> (raw)
In-Reply-To: <8f2776cb0601111639r61642795la665387645e44bfa@mail.gmail.com>

Jim Blandy wrote:
> On 1/11/06, Mark Mitchell <mark@codesourcery.com> wrote:
> 
>>        gdb_assert (!FD_ISSET (fd, writefds));
>>!       if (FD_ISSET (fd, readfds)
>>!         && !FD_ISSET (fd, exceptfds))
>>!       continue;
> 
> 
> Don't you mean, "if (! FD_ISSET (fd, readfds) && ..."?

Definitely.

I got lucky because GDB (at least in simple cases) tends to pass the
same set of descriptors for readfds and exceptfds.

OK with that change?

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


  reply	other threads:[~2006-01-12 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-12  0:11 Mark Mitchell
2006-01-12  0:39 ` Jim Blandy
2006-01-12 15:57   ` Mark Mitchell [this message]
2006-01-12 20:22     ` Jim Blandy
2006-01-12 20:40       ` Christopher Faylor
2006-01-14  5:14         ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43C67C4C.7090605@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox